Skip to content

fix: fix pollstatus issue #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: fix pollstatus issue #435

wants to merge 1 commit into from
+3 −4

Conversation

wyangsun
Copy link

@wyangsun wyangsun commented Jul 1, 2025 •
edited
Loading

  • fix the issue where the pollstatus was not working correctly
  • fix the issue where the vectorstoreid was not being passed correctly in example

Error logs:

go run main.go -- test0.txt test1.txt
File to upload: test0.txt
File to upload: test1.txt
Creating a new vector store and uploading files
panic: vector store file batch poll: received GET "https://api.openai.com/v1/vector_stores/vsfb_***/file_batches/vs_***": 400 Bad Request {
            "message": "Invalid 'batch_id': 'vs_686329ef3c6081918a21b7a9fa904dd4'. Expected an ID that begins with 'vsfb_'.",
            "type": "invalid_request_error",
            "param": "batch_id",
            "code": "invalid_value"
          }

goroutine 1 [running]:
main.main()

@wyangsun
fix: fix pollstatus issue
39ac16d 
- fix the issue where the pollstatus was not working correctly
- fix the issue where the vectorstoreid was not being passed correctly
- fix the issue where the vectorstoreid was not being passed correctly
@wyangsun wyangsun requested a review from a team as a code owner July 1, 2025 05:50
@yekkhan-liftoff
Copy link

@jacobzim-stl Hi Jacob! Could you please take a look at this PR? Thank you.

@kolatat
Copy link

kolatat commented Aug 31, 2025

file ID and vector store ID seem to be mixed up / swapped in VectorStoreFileService.PollStatus also

call is r.Get(ctx, fileID, vectorStoreID, opts...)
but signature is Get(ctx context.Context, vectorStoreID string, fileID string, opts ...option.RequestOption)
resulting in an incorrect request URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wyangsun @yekkhan-liftoff @kolatat