release: 0.14.1 (#161)

* chore: add max retries to test (#160)

* fix(client): async streaming flakiness (#162)

* chore(internal): fix release (#163)

* release: 0.14.1

---------

Co-authored-by: stainless-app[bot] <142633134+stainless-app[bot]@users.noreply.github.com>

Author: stainless-app[bot]

.release-please-manifest.json

@@ -1,3 +1,3 @@
 {
-  ".": "0.14.0"
+  ".": "0.14.1"
 }

CHANGELOG.md

@@ -1,5 +1,19 @@
 # Changelog
 
+## 0.14.1 (2025-01-25)
+
+Full Changelog: [v0.14.0...v0.14.1](https://github.com/openai/openai-java/compare/v0.14.0...v0.14.1)
+
+### Bug Fixes
+
+* **client:** async streaming flakiness ([#162](https://github.com/openai/openai-java/issues/162)) ([247c05a](https://github.com/openai/openai-java/commit/247c05a70fecad0bc1498d5aa56e13310f36eb96))
+
+
+### Chores
+
+* add max retries to test ([#160](https://github.com/openai/openai-java/issues/160)) ([7c4a4e0](https://github.com/openai/openai-java/commit/7c4a4e034c5edaea804435972f558df6a9326220))
+* **internal:** fix release ([#163](https://github.com/openai/openai-java/issues/163)) ([987fa44](https://github.com/openai/openai-java/commit/987fa4409a86636bbe87fee77522a1659e263f3b))
+
 ## 0.14.0 (2025-01-24)
 
 Full Changelog: [v0.13.0...v0.14.0](https://github.com/openai/openai-java/compare/v0.13.0...v0.14.0)

README.md

@@ -9,8 +9,8 @@
 
 <!-- x-release-please-start-version -->
 
-[![Maven Central](https://img.shields.io/maven-central/v/com.openai/openai-java)](https://central.sonatype.com/artifact/com.openai/openai-java/0.14.0)
-[![javadoc](https://javadoc.io/badge2/com.openai/openai-java/0.14.0/javadoc.svg)](https://javadoc.io/doc/com.openai/openai-java/0.14.0)
+[![Maven Central](https://img.shields.io/maven-central/v/com.openai/openai-java)](https://central.sonatype.com/artifact/com.openai/openai-java/0.14.1)
+[![javadoc](https://javadoc.io/badge2/com.openai/openai-java/0.14.1/javadoc.svg)](https://javadoc.io/doc/com.openai/openai-java/0.14.1)
 
 <!-- x-release-please-end -->
 
@@ -25,7 +25,7 @@ The REST API documentation can be found on [platform.openai.com](https://platfor
 ### Gradle
 
 ```kotlin
-implementation("com.openai:openai-java:0.14.0")
+implementation("com.openai:openai-java:0.14.1")
 ```
 
 ### Maven
@@ -34,7 +34,7 @@ implementation("com.openai:openai-java:0.14.0")
 <dependency>
     <groupId>com.openai</groupId>
     <artifactId>openai-java</artifactId>
-    <version>0.14.0</version>
+    <version>0.14.1</version>
 </dependency>
 ```
 

build.gradle.kts

@@ -8,9 +8,16 @@ repositories {
 
 allprojects {
     group = "com.openai"
-    version = "0.14.0" // x-release-please-version
+    version = "0.14.1" // x-release-please-version
 }
 
 subprojects {
     apply(plugin = "org.jetbrains.dokka")
 }
+
+// Avoid race conditions between `dokkaJavadocCollector` and `dokkaJavadocJar` tasks
+tasks.named("dokkaJavadocCollector").configure {
+    subprojects.flatMap { it.tasks }
+        .filter { it.project.name != "openai-java" && it.name == "dokkaJavadocJar" }
+        .forEach { mustRunAfter(it) }
+}

openai-java-core/src/main/kotlin/com/openai/core/http/PhantomReachableClosingAsyncStreamResponse.kt

@@ -2,6 +2,7 @@ package com.openai.core.http
 
 import com.openai.core.closeWhenPhantomReachable
 import com.openai.core.http.AsyncStreamResponse.Handler
+import java.util.Optional
 import java.util.concurrent.Executor
 
 internal class PhantomReachableClosingAsyncStreamResponse<T>(
@@ -12,13 +13,30 @@ internal class PhantomReachableClosingAsyncStreamResponse<T>(
     }
 
     override fun subscribe(handler: Handler<T>): AsyncStreamResponse<T> = apply {
-        asyncStreamResponse.subscribe(handler)
+        asyncStreamResponse.subscribe(HandlerReferencingAsyncStreamResponse(handler, this))
     }
 
     override fun subscribe(handler: Handler<T>, executor: Executor): AsyncStreamResponse<T> =
         apply {
-            asyncStreamResponse.subscribe(handler, executor)
+            asyncStreamResponse.subscribe(
+                HandlerReferencingAsyncStreamResponse(handler, this),
+                executor
+            )
         }
 
     override fun close() = asyncStreamResponse.close()
 }
+
+/**
+ * A wrapper around a `Handler` that also references an `AsyncStreamResponse` so that the latter
+ * will not only be phantom reachable and get reclaimed early while the handler itself is reachable
+ * and subscribed to the response.
+ */
+private class HandlerReferencingAsyncStreamResponse<T>(
+    private val handler: Handler<T>,
+    private val asyncStreamResponse: AsyncStreamResponse<T>
+) : Handler<T> {
+    override fun onNext(value: T) = handler.onNext(value)
+
+    override fun onComplete(error: Optional<Throwable>) = handler.onComplete(error)
+}

openai-java-core/src/test/kotlin/com/openai/core/http/RetryingHttpClientTest.kt

@@ -45,6 +45,7 @@ internal class RetryingHttpClientTest {
         val retryingClient =
             RetryingHttpClient.builder()
                 .httpClient(httpClient)
+                .maxRetries(2)
                 .idempotencyHeader("X-Some-Header")
                 .build()
         val response = retryingClient.execute(request)