Skip to content

Technical debt contribution #1688

@jdiaz-dev

Description

@jdiaz-dev

Confirm this is a Node library issue and not an underlying OpenAI API issue

  • This is an issue with the Node library

Describe the bug

I found many internal technical debt while I am reading codebase
One example of it is in src/lib/EventStream.ts in the line 220 where there is one not implemented method
protected _emitFinal(): void {}

also in the same file in line 47 there is one call to the previous not implemented method
this._emitFinal();

My doubt about it is if for this library you are accepting only functional and bugs issues contributions or you are also accepting internal enhancements contributions

To Reproduce

  1. Without reproduction it is technical debt

Code snippets

OS

macOS

Node version

Node v20.19.0

Library version

openai v6.5.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions