[WIP] Add new tool call streaming system #1713
Draft
+2,697
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+2
to
+3
| import type { infer as zodInfer, ZodType } from 'zod'; | ||
| import * as z from 'zod'; |
Collaborator
There was a problem hiding this comment.
nit: these should use v4 imports https://zod.dev/library-authors#how-to-support-zod-3-and-zod-4-simultaneously
| chatkit: ChatKitAPI.ChatKit = new ChatKitAPI.ChatKit(this._client); | ||
| assistants: AssistantsAPI.Assistants = new AssistantsAPI.Assistants(this._client); | ||
| threads: ThreadsAPI.Threads = new ThreadsAPI.Threads(this._client); | ||
| chat: ChatAPI.Chat = new ChatAPI.Chat(this._client); |
Collaborator
There was a problem hiding this comment.
you should define a sibling chat.ts file in this directory and define a new class there instead of adding toolRunner() to the existing resource class, as now it'll be accessible from client.chat.completions.toolRunner() which isn't what we want yet
update types start setting up tests get non streaming working begin work on modifying anthropic tests to openai update models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
Update the tool call pattern to use a new async iterable style pattern that makes more easily accessible tool calls as they are fired, and API responses.
Additional context & links