chore(client): throw specific errors

Author: dtmeadows

lib/openai/errors.rb

@@ -8,6 +8,9 @@ class Error < StandardError
       #   @return [StandardError, nil]
     end
 
+    class InvalidWebhookSignatureError < OpenAI::Errors::Error
+    end
+
     class ConversionError < OpenAI::Errors::Error
       # @return [StandardError, nil]
       def cause = @cause.nil? ? super : @cause

lib/openai/resources/webhooks.rb

@@ -21,7 +21,7 @@ def unwrap(
         webhook_secret = @client.webhook_secret || ENV["OPENAI_WEBHOOK_SECRET"]
       )
         verify_signature(payload, headers, webhook_secret)
-        
+
         parsed = JSON.parse(payload, symbolize_names: true)
         OpenAI::Internal::Type::Converter.coerce(OpenAI::Models::Webhooks::UnwrapWebhookEvent, parsed)
       end
@@ -73,11 +73,11 @@ def verify_signature(
         now = Time.now.to_i
 
         if now - timestamp_seconds > tolerance
-          raise ArgumentError, "Webhook timestamp is too old"
+          raise OpenAI::Errors::InvalidWebhookSignatureError, "Webhook timestamp is too old"
         end
 
         if timestamp_seconds > now + tolerance
-          raise ArgumentError, "Webhook timestamp is too new"
+          raise OpenAI::Errors::InvalidWebhookSignatureError, "Webhook timestamp is too new"
         end
 
         # Extract signatures from v1,<base64> format
@@ -109,7 +109,8 @@ def verify_signature(
         # Accept if any signature matches using timing-safe comparison
         return if signatures.any? { |signature| OpenSSL.secure_compare(expected_signature, signature) }
 
-        raise ArgumentError, "The given webhook signature does not match the expected signature"
+        raise OpenAI::Errors::InvalidWebhookSignatureError,
+              "The given webhook signature does not match the expected signature"
       end
 
       # @api private

test/openai/resources/webhooks_test.rb

@@ -38,7 +38,7 @@ def test_verify_signature_with_invalid_secret
       "webhook-id" => @webhook_id
     }
 
-    assert_raises(ArgumentError) do
+    assert_raises(OpenAI::Errors::InvalidWebhookSignatureError) do
       @webhook_service.verify_signature(@test_payload, headers, "invalid_secret")
     end
   end
@@ -60,7 +60,7 @@ def test_verify_signature_with_old_timestamp
       "webhook-id" => @webhook_id
     }
 
-    assert_raises(ArgumentError) do
+    assert_raises(OpenAI::Errors::InvalidWebhookSignatureError) do
       @webhook_service.verify_signature(@test_payload, headers, @test_secret)
     end
   end
@@ -90,7 +90,7 @@ def test_verify_signature_with_custom_tolerance
     }
 
     # Should fail due to old timestamp
-    assert_raises(ArgumentError) do
+    assert_raises(OpenAI::Errors::InvalidWebhookSignatureError) do
       @webhook_service.verify_signature(@test_payload, headers, @test_secret, 300)
     end
   end
@@ -136,7 +136,7 @@ def test_verify_signature_with_multiple_signatures_all_invalid
       "webhook-id" => @webhook_id
     }
 
-    assert_raises(ArgumentError) do
+    assert_raises(OpenAI::Errors::InvalidWebhookSignatureError) do
       @webhook_service.verify_signature(@test_payload, headers, @test_secret)
     end
   end