fix: pages should be able to accept non-converter models (#60)

stainless-app[bot] · stainless-app[bot] · commit 492fa38f3a12 · 2025-03-21T12:32:33.000Z
diff --git a/lib/openai/cursor_page.rb b/lib/openai/cursor_page.rb
@@ -43,7 +43,7 @@ def initialize(client:, req:, headers:, page_data:)
 
       case page_data
       in {data: Array | nil => data}
-        @data = data&.map { model.coerce(_1) }
+        @data = data&.map { OpenAI::Converter.coerce(model, _1) }
       else
       end
 
diff --git a/lib/openai/page.rb b/lib/openai/page.rb
@@ -43,7 +43,7 @@ def initialize(client:, req:, headers:, page_data:)
 
       case page_data
       in {data: Array | nil => data}
-        @data = data&.map { model.coerce(_1) }
+        @data = data&.map { OpenAI::Converter.coerce(model, _1) }
       else
       end
 
diff --git a/test/openai/resources/batches_test.rb b/test/openai/resources/batches_test.rb
@@ -82,6 +82,8 @@ def test_list
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => OpenAI::Models::Batch
     end
diff --git a/test/openai/resources/beta/assistants_test.rb b/test/openai/resources/beta/assistants_test.rb
@@ -89,6 +89,8 @@ def test_list
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => OpenAI::Models::Beta::Assistant
     end
diff --git a/test/openai/resources/beta/threads/messages_test.rb b/test/openai/resources/beta/threads/messages_test.rb
@@ -92,6 +92,8 @@ def test_list
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => OpenAI::Models::Beta::Threads::Message
     end
diff --git a/test/openai/resources/beta/threads/runs/steps_test.rb b/test/openai/resources/beta/threads/runs/steps_test.rb
@@ -40,6 +40,8 @@ def test_list_required_params
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => OpenAI::Models::Beta::Threads::Runs::RunStep
     end
diff --git a/test/openai/resources/beta/threads/runs_test.rb b/test/openai/resources/beta/threads/runs_test.rb
@@ -131,6 +131,8 @@ def test_list
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => OpenAI::Models::Beta::Threads::Run
     end
diff --git a/test/openai/resources/chat/completions/messages_test.rb b/test/openai/resources/chat/completions/messages_test.rb
@@ -11,6 +11,8 @@ def test_list
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => OpenAI::Models::Chat::ChatCompletionStoreMessage
     end
diff --git a/test/openai/resources/chat/completions_test.rb b/test/openai/resources/chat/completions_test.rb
@@ -75,6 +75,8 @@ def test_list
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => OpenAI::Models::Chat::ChatCompletion
     end
diff --git a/test/openai/resources/files_test.rb b/test/openai/resources/files_test.rb
@@ -55,6 +55,8 @@ def test_list
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => OpenAI::Models::FileObject
     end
diff --git a/test/openai/resources/fine_tuning/jobs/checkpoints_test.rb b/test/openai/resources/fine_tuning/jobs/checkpoints_test.rb
@@ -11,6 +11,8 @@ def test_list
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => OpenAI::Models::FineTuning::Jobs::FineTuningJobCheckpoint
     end
diff --git a/test/openai/resources/fine_tuning/jobs_test.rb b/test/openai/resources/fine_tuning/jobs_test.rb
@@ -75,6 +75,8 @@ def test_list
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => OpenAI::Models::FineTuning::FineTuningJob
     end
@@ -144,6 +146,8 @@ def test_list_events
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => OpenAI::Models::FineTuning::FineTuningJobEvent
     end
diff --git a/test/openai/resources/models_test.rb b/test/openai/resources/models_test.rb
@@ -28,6 +28,8 @@ def test_list
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => OpenAI::Models::Model
     end
diff --git a/test/openai/resources/responses/input_items_test.rb b/test/openai/resources/responses/input_items_test.rb
@@ -11,6 +11,8 @@ def test_list
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => OpenAI::Models::Responses::ResponseItem
     end
diff --git a/test/openai/resources/vector_stores/file_batches_test.rb b/test/openai/resources/vector_stores/file_batches_test.rb
@@ -68,6 +68,8 @@ def test_list_files_required_params
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => OpenAI::Models::VectorStores::VectorStoreFile
     end
diff --git a/test/openai/resources/vector_stores/files_test.rb b/test/openai/resources/vector_stores/files_test.rb
@@ -82,6 +82,8 @@ def test_list
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => OpenAI::Models::VectorStores::VectorStoreFile
     end
@@ -125,6 +127,8 @@ def test_content_required_params
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => OpenAI::Models::VectorStores::FileContentResponse
     end
diff --git a/test/openai/resources/vector_stores_test.rb b/test/openai/resources/vector_stores_test.rb
@@ -83,6 +83,8 @@ def test_list
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => OpenAI::Models::VectorStore
     end
@@ -128,6 +130,8 @@ def test_search_required_params
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => OpenAI::Models::VectorStoreSearchResponse
     end
