Skip to content

Commit 1e96c77

Browse files
authored
Improve scripting component (#75)
2 parents 9bb879e + 3865d8f commit 1e96c77

File tree

10 files changed

+232
-217
lines changed

10 files changed

+232
-217
lines changed

openandroidinstaller/openandroidinstaller.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -193,21 +193,18 @@ def log_version_infos(bin_path):
193193
"""Log the version infos of adb, fastboot and heimdall."""
194194
# adb
195195
adbversion = [
196-
line for line in run_command("adb", ["version"], bin_path, enable_logging=False)
196+
line for line in run_command("adb version", bin_path, enable_logging=False)
197197
]
198198
logger.info(f"{adbversion[1].strip()}")
199199
# fastboot
200200
fbversion = [
201201
line
202-
for line in run_command(
203-
"fastboot", ["--version"], bin_path, enable_logging=False
204-
)
202+
for line in run_command("fastboot --version", bin_path, enable_logging=False)
205203
]
206204
logger.info(f"{fbversion[1].strip()}")
207205
# heimdall
208206
hdversion = [
209-
line
210-
for line in run_command("heimdall", ["info"], bin_path, enable_logging=False)
207+
line for line in run_command("heimdall info", bin_path, enable_logging=False)
211208
]
212209
logger.info(f"Heimdall version: {hdversion[1].strip()}")
213210

0 commit comments

Comments
 (0)