Improve build quality (#24)

- Add more binaries to the builds
- Update contribution guidelines
- Use a proper build script
- Clean-up unused scripts

Author: tsterbak

.github/workflows/manual-build-windows.yml

@@ -10,7 +10,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: ['ubuntu-latest', 'macos-latest']
+        os: ['ubuntu-latest', 'macos-latest', 'windows-latest']
 
     steps:
     - uses: actions/checkout@v2
@@ -19,7 +19,7 @@ jobs:
         python-version: 3.9
     - run: pip install -r requirements.txt
     - run: python scripts/download-tools.py
-    - run: pyinstaller openandroidinstaller/openandroidinstaller.py --noconsole --noconfirm --onefile --icon "openandroidinstaller/assets/favicon.ico" --add-data "openandroidinstaller/assets:assets" --add-binary "openandroidinstaller/bin/adb:bin" --add-binary "openandroidinstaller/bin/fastboot:bin" --add-binary "openandroidinstaller/bin/heimdall:bin" --windowed
+    - run: python scripts/build.py
     # Optionally verify that it works (provided that it does not need user interaction)
     #- run: ./dist/your-code/your-code
     - uses: actions/upload-artifact@v3

.github/workflows/manual-build.yml

@@ -15,7 +15,7 @@ app:
 	poetry run python openandroidinstaller/openandroidinstaller.py
 
 build-app:
-	poetry run pyinstaller openandroidinstaller/openandroidinstaller.py --noconsole --noconfirm --onefile --icon "openandroidinstaller/assets/favicon.ico" --add-data "openandroidinstaller/assets:assets" --add-binary "openandroidinstaller/bin/adb:bin" --add-binary "openandroidinstaller/bin/fastboot:bin" --add-binary "openandroidinstaller/bin/heimdall:bin" --windowed
+	poetry run python scripts/build.py
 
 clean-build:
 	rm -rf build/ dist/

Makefile

@@ -57,7 +57,7 @@ Linux is currently the best supported platform (tested with Ubuntu 20.04 LTS). W
 
 ## Run OpenAndroidInstaller for development
 
-Currently development is only supported on Ubuntu Linux. MacOS should also work fine.
+Currently development is only supported on Ubuntu Linux. MacOS and Windows should also work fine. You might need to install additional USB-drivers on Windows.
 
 1. Clone the main branch of this repository
 2. Run `make poetry` and `make install` to install poetry to manage python and install the required dependencies like adb, fastboot and heimdall.
@@ -66,7 +66,14 @@ Currently development is only supported on Ubuntu Linux. MacOS should also work
 
 ## Contributing
 
-### Contribute your own installation configurations
+All kinds of contributions are welcome. These include:
+- Fix and improve texts in configs and in the application.
+- Test the tool for a supported device.
+- Create a config for a new device.
+- Test the application on your computer.
+- Contribute an application build for a new platform.
+
+### How to contribute your own installation configurations
 
 If you want to use the tool for a non-supported smartphone, the fastest way is to adapt an [existing config file](https://github.com/openandroidinstaller-dev/openandroidinstaller/tree/main/openandroidinstaller/assets/configs).
 
@@ -92,7 +99,15 @@ The file should be named after device name output by `adb shell getprop | grep r
 To test your config file with the executable without using the developer setup, place it in the same directory as the executable. There it will be detected by name. 
 After you created a config file and it works fine, you can open a pull request to make the file available to other users. Please also add the device to the supported devices table above.
 
+### How to build the application for your platform
+
+The executables for the OpenAndroidInstaller are build with [pyinstaller](https://pyinstaller.org/en/stable/index.html). You can create builds for MacOS or Linux with `make build-app`. For Windows the paths need to be modified. For now, you can have a look [here](https://github.com/openandroidinstaller-dev/openandroidinstaller/blob/v0.1.2-alpha/.github/workflows/manual-build-windows.yml#L22) on how it's done.
+
+If you build the application for your platform and want to contribute the build, please reach out to me.
+
 #### On unlocking the bootloader
+Devices by *Samsung*, *Google* and *Fairphone* make it fairly easy to unlock the bootloader and receive good support in the installer.
+
 Some devices with require manual steps to unlock the bootloader. In general you will need to create an account at a vendor website and receive some code from there. OpenAndroidInstaller will try to guide you as far as possible. These vendors include *Sony, Motorola, Xiaomi* among others.
 
 Other phone vendors stops allowing to unlock the bootloader all together. There is nothing to be done if you didn't unlock your device in time. These vendors include *Huawei and LG* among others. Support for these vendors will always be very limited.