Skip to content

Commit b0110dd

Browse files
authored
Fix errorhandling for image_sdk_level
1 parent 6da6055 commit b0110dd

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

openandroidinstaller/utils.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,6 @@ def retrieve_image_metadata(image_path: str) -> dict:
8585
logger.info(f"Metadata retrieved from image {image_path.split('/')[-1]}.")
8686
return metadata_dict
8787
except zipfile.BadZipFile as e:
88-
logger.error("Selected image is not a zip file.")
8988
raise e
9089
except (FileNotFoundError, KeyError):
9190
logger.error(
@@ -110,12 +109,12 @@ def image_sdk_level(image_path: str) -> int:
110109
Returns:
111110
Android version as integer.
112111
"""
113-
metadata = retrieve_image_metadata(image_path)
114112
try:
113+
metadata = retrieve_image_metadata(image_path)
115114
sdk_level = metadata["post-sdk-level"]
116115
logger.info(f"Android version of {image_path}: {sdk_level}")
117116
return int(sdk_level)
118-
except (ValueError, TypeError, KeyError) as e:
117+
except (ValueError, TypeError, KeyError, zipfile.BadZipFile) as e:
119118
logger.error(f"Could not determine Android version of {image_path}. Error: {e}")
120119
return -1
121120

@@ -149,6 +148,7 @@ def image_works_with_device(
149148
f"Image file {image_path.split('/')[-1]} is not supported by device code.",
150149
)
151150
except zipfile.BadZipFile:
151+
logger.error("Selected image is not a zip file.")
152152
return CheckResult(
153153
CompatibilityStatus.INCOMPATIBLE,
154154
f"Selected image {image_path.split('/')[-1]} is not a zip file.",

0 commit comments

Comments
 (0)