Skip to content

Commit ff63520

Browse files
committed
Prevent failing when progress goes over 100%
1 parent d3d703f commit ff63520

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

openandroidinstaller/widgets.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ def display_progress_bar(self, line: str):
141141
percentage_done = int(result.group(1))
142142
if percentage_done == 0:
143143
percentage_done = 1
144-
elif percentage_done == 100:
144+
elif percentage_done >= 100:
145145
percentage_done = 99
146146

147147
# update the progress bar
@@ -153,9 +153,10 @@ def set_progress_bar(self, percentage_done: int):
153153
Args:
154154
percentage_done (int): Percentage of the progress bar to be filled.
155155
"""
156-
assert (
157-
percentage_done >= 0 and percentage_done <= 100
158-
), "Percentage must be between 0 and 100"
156+
assert percentage_done >= 0, "Percentage must be non-negative."
157+
# clip the percentage to 100
158+
if percentage_done > 100:
159+
percentage_done = 100
159160
if self.progress_bar:
160161
self.progress_bar.value = percentage_done / 100
161162
self.percentage_text.value = f"{percentage_done}%"

0 commit comments

Comments
 (0)