Allow schema-less responses (#565)

Author: drwpow

src/transform/responses.ts

@@ -47,10 +47,11 @@ export function transformResponsesObj(responsesObj: Record<string, any>, options
       // V3
       output += `    ${readonly}content: {\n`; // open content
       Object.entries(response.content).forEach(([contentType, contentResponse]) => {
-        output += `      ${readonly}"${contentType}": ${transformSchemaObj(
-          (contentResponse as any).schema,
-          options
-        )};\n`;
+        const responseType =
+          contentResponse && (contentResponse as any).schema
+            ? transformSchemaObj((contentResponse as any).schema, options)
+            : "unknown";
+        output += `      ${readonly}"${contentType}": ${responseType};\n`;
       });
       output += `    }\n`; //close content
     } else if (response.schema) {

src/utils.ts

@@ -63,13 +63,18 @@ export function nodeType(obj: any): SchemaObjectType | undefined {
 export function swaggerVersion(definition: OpenAPI2 | OpenAPI3): 2 | 3 {
   // OpenAPI 3
   if ("openapi" in definition) {
+    // OpenAPI version requires semver, therefore will always be string
     if (parseInt(definition.openapi, 10) === 3) {
       return 3;
     }
   }
 
   // OpenAPI 2
   if ("swagger" in definition) {
+    // note: swagger 2.0 may be parsed as a number
+    if (typeof definition.swagger === "number" && Math.round(definition.swagger as number) === 2) {
+      return 2;
+    }
     if (parseInt(definition.swagger, 10) === 2) {
       return 2;
     }

tests/paths.test.ts

@@ -155,11 +155,17 @@ describe("transformPathsObj", () => {
 }\n`);
   });
 
-  it("empty responses (#333)", () => {
+  it("empty responses (#333, #536)", () => {
     const emptyResponsesSchema = {
       "/no-content": {
         get: {
           responses: {
+            200: {
+              description: "OK",
+              content: {
+                "application/json": {},
+              },
+            },
             204: {
               description: "Empty response",
             },
@@ -190,6 +196,12 @@ describe("transformPathsObj", () => {
   "/no-content": {
     get: {
       responses: {
+        /** OK */
+        200: {
+          content: {
+            "application/json": unknown;
+          };
+        };
         /** Empty response */
         204: never;
       };
@@ -217,6 +229,12 @@ describe("transformPathsObj", () => {
   readonly "/no-content": {
     readonly get: {
       readonly responses: {
+        /** OK */
+        readonly 200: {
+          readonly content: {
+            readonly "application/json": unknown;
+          };
+        };
         /** Empty response */
         readonly 204: never;
       };