Fix fetching (#1719)

Author: drwpow

.changeset/fresh-icons-draw.md

@@ -0,0 +1,5 @@
+---
+"openapi-fetch": patch
+---
+
+Remove nanoid from dependencies

.changeset/little-snails-shake.md

@@ -0,0 +1,5 @@
+---
+"openapi-fetch": patch
+---
+
+Fix "failed to execute fetch on Window" error

.changeset/twenty-nails-change.md

@@ -0,0 +1,5 @@
+---
+"openapi-fetch": patch
+---
+
+Revert customFetch API back to `fetch(input: Request)`

.github/workflows/ci.yml

@@ -39,6 +39,19 @@ jobs:
           run_install: true
       - run: pnpm run build
       - run: pnpm test
+  test-e2e:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 22
+      - uses: pnpm/action-setup@v4
+        with:
+          version: latest
+          run_install: true
+      - run: pnpm exec playwright install --with-deps
+      - run: pnpm run test-e2e
   test-macos:
     runs-on: macos-latest
     steps:

package.json

@@ -12,14 +12,18 @@
     "lint": "pnpm run -r --parallel --aggregate-output lint",
     "format": "pnpm run -r --parallel --aggregate-output format",
     "test": "pnpm run -r --parallel --aggregate-output test",
+    "test-e2e": "pnpm run -r --parallel --aggregate-output test-e2e",
     "version": "pnpm run build && changeset version && pnpm i"
   },
   "devDependencies": {
     "@biomejs/biome": "^1.8.1",
     "@changesets/changelog-github": "^0.5.0",
     "@changesets/cli": "^2.27.5",
+    "@playwright/test": "^1.44.1",
+    "@types/node": "^20.14.7",
     "del-cli": "^5.1.0",
     "prettier": "^3.3.2",
-    "typescript": "^5.4.5"
+    "typescript": "^5.4.5",
+    "vitest": "^1.6.0"
   }
 }

packages/openapi-fetch/examples/nextjs/package.json

@@ -12,7 +12,6 @@
     "react-dom": "18.3.1"
   },
   "devDependencies": {
-    "@types/node": "20.14.6",
     "@types/react": "18.3.1",
     "@types/react-dom": "18.3.0",
     "openapi-typescript": "workspace:^",

packages/openapi-fetch/examples/vue-3/package.json

@@ -16,7 +16,6 @@
   },
   "devDependencies": {
     "@tsconfig/node20": "^20.1.4",
-    "@types/node": "^20.14.6",
     "@vitejs/plugin-vue": "^5.0.5",
     "@vue/tsconfig": "^0.5.1",
     "openapi-typescript": "workspace:^",

packages/openapi-fetch/package.json

@@ -54,15 +54,17 @@
     "build:cjs": "esbuild --bundle src/index.js --format=cjs --outfile=dist/cjs/index.cjs && cp dist/index.d.ts dist/cjs/index.d.cts",
     "format": "biome format . --write",
     "lint": "biome check .",
-    "generate-types": "openapi-typescript test/fixtures/api.yaml -o test/fixtures/api.d.ts",
+    "generate-types": "openapi-typescript -c test/redocly.yaml",
     "pretest": "pnpm run generate-types",
     "test": "pnpm run \"/^test:/\"",
     "test:js": "vitest run",
     "test:ts": "tsc --noEmit",
+    "test-e2e": "playwright test",
+    "e2e-vite-build": "vite build test/fixtures/e2e",
+    "e2e-vite-start": "vite preview test/fixtures/e2e",
     "version": "pnpm run prepare && pnpm run build"
   },
   "dependencies": {
-    "nanoid": "^5.0.7",
     "openapi-typescript-helpers": "workspace:^"
   },
   "devDependencies": {
@@ -76,6 +78,6 @@
     "openapi-typescript-fetch": "^2.0.0",
     "superagent": "^9.0.2",
     "typescript": "^5.4.5",
-    "vitest": "^1.6.0"
+    "vite": "^5.3.1"
   }
 }

packages/openapi-fetch/playwright.config.ts

@@ -0,0 +1,28 @@
+import { defineConfig, devices } from "@playwright/test";
+
+const PORT = Number.parseInt(process.env.PORT || 4173 || "", 10);
+
+export default defineConfig({
+  testMatch: "test/**/*.e2e.ts",
+  webServer: {
+    command: "pnpm run e2e-vite-build && pnpm run e2e-vite-start",
+    port: PORT,
+  },
+  use: {
+    baseURL: `http://localhost:${PORT}`,
+  },
+  projects: [
+    {
+      name: "chrome",
+      use: { ...devices["Desktop Chrome"] },
+    },
+    {
+      name: "firefox",
+      use: { ...devices["Desktop Firefox"] },
+    },
+    {
+      name: "webkit",
+      use: { ...devices["Desktop Safari"] },
+    },
+  ],
+});

packages/openapi-fetch/src/index.d.ts

@@ -15,7 +15,7 @@ export interface ClientOptions extends Omit<RequestInit, "headers"> {
   /** set the common root URL for all API requests */
   baseUrl?: string;
   /** custom fetch (defaults to globalThis.fetch) */
-  fetch?: (input: string, init?: RequestInit) => Promise<Response>;
+  fetch?: (input: Request) => Promise<Response>;
   /** global querySerializer */
   querySerializer?: QuerySerializer<unknown> | QuerySerializerOptions;
   /** global bodySerializer */