Skip to content

Commit 9e4de45

Browse files
committed
feat(db): cleanup Makefile database handling and env vars
1 parent 27c124e commit 9e4de45

File tree

2 files changed

+15
-8
lines changed

2 files changed

+15
-8
lines changed

src/dependencies.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ export function devDependencies({ features }: { features: string[] }) {
4848
};
4949
if (features.includes('db')) {
5050
Object.assign(deps, {
51+
'run-pg-sql': '^1.1.0',
5152
'db-migrate': '^0.11.13',
5253
'db-migrate-pg': '^1.3.0',
5354
'kysely-codegen': '^0.10.0',

templates/all/Makefile

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
src_files := $(shell find src -name '*.ts')
55
build_files := $(patsubst src/%.ts,build/%.js,$(src_files))
66

7-
PGUSER := postgres
8-
PGPASSWORD := postgres
9-
PGHOST := localhost
7+
export PGUSER ?= postgres
8+
export PGPASSWORD ?= postgres
9+
export PGHOST ?= localhost
1010

1111
all: service {{#inArray features 'db'}}dbi {{/inArray}}$(word 1, $(build_files))
1212

@@ -22,19 +22,25 @@ service: src/generated/service/index.ts
2222

2323
{{#inArray features 'db'}}
2424
db-ci:
25-
PGHOST=$(PGHOST) PGUSER=$(PGUSER) PGPASSWORD=$(PGPASSWORD) yarn dlx run-pg-sql -q postgres ./migrations/setup/ci_setup.sql
26-
PGHOST=$(PGHOST) PGUSER=$(PGUSER) PGPASSWORD=$(PGPASSWORD) yarn dlx run-pg-sql -q postgres ./migrations/setup/db_setup.sql
25+
yarn run-pg-sql -q postgres ./migrations/setup/ci_setup.sql
26+
yarn run-pg-sql -q postgres ./migrations/setup/db_setup.sql
2727
yarn migration:apply
28-
PGHOST=$(PGHOST) PGUSER=$(PGUSER) PGPASSWORD=$(PGPASSWORD) yarn dlx run-pg-sql {{dbName}} ./migrations/setup/dev_setup.sql
28+
yarn run-pg-sql {{dbName}} ./migrations/setup/dev_setup.sql
2929

3030
db-drop:
31-
PGHOST=$(PGHOST) PGUSER=$(PGUSER) PGPASSWORD=$(PGPASSWORD) yarn dlx run-pg-sql -q {{dbName}} ./migrations/setup/db_clean.sql || true
31+
yarn run-pg-sql -q {{dbName}} ./migrations/setup/db_clean.sql || true
32+
33+
db+:
34+
yarn migration:apply
35+
36+
db-:
37+
yarn migration:undo
3238

3339
db-clean: db-drop db-ci
3440

3541
dbi:
3642
echo "Generating database types"
37-
DATABASE_URL=postgres://postgres:postgres@localhost/{{dbName}} yarn kysely-codegen \
43+
DATABASE_URL=postgres://$(PGUSER):$(PGPASSWORD)@$(PGHOST)/{{dbName}} yarn kysely-codegen \
3844
--dialect postgres --schema public \
3945
--out-file src/generated/database.ts
4046
{{/inArray}}

0 commit comments

Comments
 (0)