Skip to content

Commit 7bd65ac

Browse files
committed
fix: be more careful with syntax to avoid a reserved word
1 parent baff881 commit 7bd65ac

File tree

3 files changed

+237
-239
lines changed

3 files changed

+237
-239
lines changed

package.json

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -60,21 +60,21 @@
6060
"dependencies": {
6161
"@godaddy/terminus": "^4.12.1",
6262
"@opentelemetry/api": "^1.9.0",
63-
"@opentelemetry/exporter-prometheus": "^0.52.0",
63+
"@opentelemetry/exporter-prometheus": "^0.52.1",
6464
"@opentelemetry/instrumentation-dns": "^0.37.0",
6565
"@opentelemetry/instrumentation-express": "^0.40.1",
6666
"@opentelemetry/instrumentation-generic-pool": "^0.37.0",
6767
"@opentelemetry/instrumentation-graphql": "^0.41.0",
68-
"@opentelemetry/instrumentation-http": "^0.52.0",
68+
"@opentelemetry/instrumentation-http": "^0.52.1",
6969
"@opentelemetry/instrumentation-ioredis": "^0.41.0",
7070
"@opentelemetry/instrumentation-net": "^0.37.0",
7171
"@opentelemetry/instrumentation-pg": "^0.42.0",
7272
"@opentelemetry/instrumentation-pino": "^0.40.0",
7373
"@opentelemetry/instrumentation-undici": "^0.3.0",
7474
"@opentelemetry/resource-detector-container": "^0.3.11",
7575
"@opentelemetry/resource-detector-gcp": "^0.29.10",
76-
"@opentelemetry/sdk-node": "^0.52.0",
77-
"@opentelemetry/semantic-conventions": "^1.25.0",
76+
"@opentelemetry/sdk-node": "^0.52.1",
77+
"@opentelemetry/semantic-conventions": "^1.25.1",
7878
"@sesamecare-oss/confit": "^2.2.1",
7979
"@sesamecare-oss/opentelemetry-node-metrics": "^1.0.1",
8080
"ajv": "^8.16.0",
@@ -85,7 +85,7 @@
8585
"glob": "^8.1.0",
8686
"lodash": "^4.17.21",
8787
"minimist": "^1.2.8",
88-
"pino": "^9.1.0",
88+
"pino": "^9.3.2",
8989
"read-pkg-up": "^7.0.1",
9090
"request-ip": "^3.3.0"
9191
},
@@ -95,14 +95,14 @@
9595
"@openapi-typescript-infra/coconfig": "^4.4.0",
9696
"@semantic-release/commit-analyzer": "^13.0.0",
9797
"@semantic-release/exec": "^6.0.3",
98-
"@semantic-release/github": "^10.0.6",
99-
"@semantic-release/release-notes-generator": "^14.0.0",
98+
"@semantic-release/github": "^10.1.3",
99+
"@semantic-release/release-notes-generator": "^14.0.1",
100100
"@types/cookie-parser": "^1.4.7",
101101
"@types/express": "^4.17.21",
102102
"@types/glob": "^8.1.0",
103-
"@types/lodash": "^4.17.5",
103+
"@types/lodash": "^4.17.7",
104104
"@types/minimist": "^1.2.5",
105-
"@types/node": "^20.14.2",
105+
"@types/node": "^20.14.14",
106106
"@types/request-ip": "^0.0.41",
107107
"@types/supertest": "^6.0.2",
108108
"@typescript-eslint/eslint-plugin": "^6.21.0",
@@ -111,12 +111,12 @@
111111
"eslint": "^8.57.0",
112112
"eslint-config-prettier": "^9.1.0",
113113
"eslint-plugin-import": "^2.29.1",
114-
"pino-pretty": "^11.2.0",
114+
"pino-pretty": "^11.2.2",
115115
"pinst": "^3.0.0",
116116
"supertest": "^7.0.0",
117117
"ts-node": "^10.9.2",
118118
"tsconfig-paths": "^4.2.0",
119-
"typescript": "^5.4.5",
119+
"typescript": "^5.5.4",
120120
"vitest": "^1.6.0"
121121
},
122122
"resolutions": {

src/telemetry/DummyExporter.ts

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,14 @@
1-
import { ExportResultCode } from '@opentelemetry/core';
2-
import type { SpanExporter } from '@opentelemetry/sdk-trace-base';
3-
4-
const noop: SpanExporter['export'] = (spans, resultCallback) => {
5-
setImmediate(() =>
6-
resultCallback({
7-
code: ExportResultCode.SUCCESS,
8-
}),
9-
);
10-
};
1+
import { ExportResult, ExportResultCode } from '@opentelemetry/core';
2+
import type { ReadableSpan, SpanExporter } from '@opentelemetry/sdk-trace-base';
113

124
export class DummySpanExporter implements SpanExporter {
13-
export: typeof noop = noop;
5+
export(spans: ReadableSpan[], resultCallback: (r: ExportResult) => void) {
6+
setImmediate(() =>
7+
resultCallback({
8+
code: ExportResultCode.SUCCESS,
9+
}),
10+
);
11+
}
1412

1513
async shutdown() {
1614
// Nothing to do

0 commit comments

Comments
 (0)