feat: change healthcheck http status to 200

jasisk · jasisk · commit c0f84f47ca7f · 2025-05-12T15:19:23.000-04:00
diff --git a/src/express-app/internal-server.ts b/src/express-app/internal-server.ts
@@ -17,12 +17,12 @@ export async function startInternalApp<
     if (mainApp.locals.service?.healthy) {
       try {
         const ok = await mainApp.locals.service.healthy(mainApp);
-        res.sendStatus(ok ? 204 : 500);
+        res.sendStatus(ok ? 200 : 500);
       } catch (error) {
         mainApp.locals.logger.error(error, 'Health check failed');
       }
     } else {
-      res.sendStatus(204);
+      res.sendStatus(200);
     }
   });
 

Original file line number	Diff line number	Diff line change
`@@ -17,12 +17,12 @@ export async function startInternalApp<`
`17`	`17`	`if (mainApp.locals.service?.healthy) {`
`18`	`18`	`try {`
`19`	`19`	`const ok = await mainApp.locals.service.healthy(mainApp);`
`20`		`- res.sendStatus(ok ? 204 : 500);`
	`20`	`+ res.sendStatus(ok ? 200 : 500);`
`21`	`21`	`} catch (error) {`
`22`	`22`	`mainApp.locals.logger.error(error, 'Health check failed');`
`23`	`23`	`}`
`24`	`24`	`} else {`
`25`		`- res.sendStatus(204);`
	`25`	`+ res.sendStatus(200);`
`26`	`26`	`}`
`27`	`27`	`});`
`28`	`28`