fix(snapshotAgent): don't create service account if disabled (#135)

The service account for the snapshot agent gets created even if the
snapshot agent itself is disabled. Now we check if the agent is enabled
as well as the existing create check. This skips creating a
ServiceAccount resource when it's not necessary.

Signed-off-by: Florian Ruechel <code@inexplicity.de>

Author: Javex

CHANGELOG.md

@@ -1,5 +1,9 @@
 ## Unreleased
 
+## 0.23.4
+
+- fix(snapshotAgent): don't create service account if disabled
+
 ## 0.23.3
 
 - fix(deps): switch injector to openbao-k8s with patched golang.org/x/crypto (CVE-2024-45337)

charts/openbao/Chart.yaml

@@ -3,7 +3,7 @@
 
 apiVersion: v2
 name: openbao
-version: 0.23.3
+version: 0.23.4
 appVersion: v2.4.4
 kubeVersion: ">= 1.30.0-0"
 description: Official OpenBao Chart
@@ -26,9 +26,9 @@ annotations:
   charts.openshift.io/name: Openbao
   artifacthub.io/containsSecurityUpdates: "true"
   artifacthub.io/changes: |
-    - kind: security
+    - kind: fixed
       description: |
-        fix(deps): switch injector to openbao-k8s with patched golang.org/x/crypto (CVE-2024-45337)
+        fix(snapshotAgent): don't create service account if disabled
 
 maintainers:
   - name: OpenBao

charts/openbao/README.md

@@ -1,6 +1,6 @@
 # openbao
 
-![Version: 0.23.3](https://img.shields.io/badge/Version-0.23.3-informational?style=flat-square) ![AppVersion: v2.4.4](https://img.shields.io/badge/AppVersion-v2.4.4-informational?style=flat-square)
+![Version: 0.23.4](https://img.shields.io/badge/Version-0.23.4-informational?style=flat-square) ![AppVersion: v2.4.4](https://img.shields.io/badge/AppVersion-v2.4.4-informational?style=flat-square)
 
 Official OpenBao Chart
 

charts/openbao/templates/snapshotagent-serviceaccount.yaml

@@ -1,4 +1,4 @@
-{{- if .Values.snapshotAgent.serviceAccount.create -}}
+{{- if and .Values.snapshotAgent.enabled .Values.snapshotAgent.serviceAccount.create -}}
 apiVersion: v1
 kind: ServiceAccount
 metadata: