auth-aws: update partition to region lookup for AWS SDK v2 #50
+104
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API we rely on currently "was intentionally removed from the v2 SDK" (see aws/aws-sdk-go-v2#557). As there is no more (pulbic) API in the AWS Go SDK, I replaced this with a little bash/jq to generate go code from the `partitions.json` file, which seems to also be used as input for their different SDKs (e.g. Go, Java and Ruby). See: openbao#5 Signed-off-by: Philipp Stehle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API we rely on currently "was intentionally removed from the v2 SDK" (see aws/aws-sdk-go-v2#557).
As there is no more (pulbic) API in the AWS Go SDK, I replaced this with a little bash/jq to generate go code from the
partitions.jsonfile, which seems to also be used as input for their different SDKs (e.g. Go, Java and Ruby).This is part of fixing #5, as there are quite some changes needed, I decided to break this down into smaller PRs.