Impedance test fix for simulator with daisy module #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
==========================================
+ Coverage 95.13% 96.31% +1.17%
==========================================
Files 2 2
Lines 1234 1870 +636
Branches 309 571 +262
==========================================
+ Hits 1174 1801 +627
- Misses 60 69 +9
Continue to review full report at Codecov.
|
|
Hey @agneg thanks so much for the pull request! The continuous integration picked up on two errors with linting. If you see linting issues hold up a pull request in the future, you can run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With daisy module now calculates impedance for all 16 channels. Also does not ignore samples used in impedance calculation(not sure if that is the way it should be though).