Skip to content

Commit f15c2e0

Browse files
committed
improvements after review
1 parent eeca984 commit f15c2e0

File tree

3 files changed

+19
-11
lines changed

3 files changed

+19
-11
lines changed

src/pages/putaway/list/PutawayListPage.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,10 @@ class PutawayListPage extends BasePageModel {
1313
this.table = new PutawayListTable(page);
1414
}
1515

16-
async goToPage() {
17-
await this.page.goto('./order/list?orderType=PUTAWAY_ORDER&status=PENDING');
18-
}
19-
20-
async waitForResponse() {
21-
await this.page.waitForResponse('./api/stockMovements?**');
16+
async goToPage(status = 'PENDING') {
17+
await this.page.goto(
18+
'./order/list?orderType=PUTAWAY_ORDER&status=' + `${status}`
19+
);
2220
}
2321

2422
async isLoaded() {

src/pages/stockMovementShow/StockMovementShowPage.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ class StockMovementShowPage extends BasePageModel {
102102
return this.page.locator('div.error');
103103
}
104104

105-
get informationMessage() {
105+
get rollbackReceiptInformationMessage() {
106106
return this.page.getByRole('status', { name: 'message' });
107107
}
108108

src/tests/putaway/rollbackLastReceiptWhenPutawayCreated.test.ts

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,14 @@ test.describe('Rollback last receipt behavior when putaway created', () => {
122122
await stockMovementShowPage.isLoaded();
123123
await expect(stockMovementShowPage.statusTag).toHaveText('Received');
124124
await stockMovementShowPage.rollbackLastReceiptButton.click();
125+
await expect(
126+
stockMovementShowPage.rollbackReceiptInformationMessage
127+
).toBeVisible();
128+
await expect(
129+
stockMovementShowPage.rollbackReceiptInformationMessage
130+
).toContainText(
131+
'Successfully rolled back last receipt in stock movement '
132+
);
125133
await expect(stockMovementShowPage.statusTag).toHaveText('Shipped');
126134
});
127135

@@ -169,10 +177,12 @@ test.describe('Rollback last receipt behavior when putaway created', () => {
169177
await stockMovementShowPage.isLoaded();
170178
await expect(stockMovementShowPage.statusTag).toHaveText('Received');
171179
await stockMovementShowPage.rollbackLastReceiptButton.click();
172-
await expect(stockMovementShowPage.informationMessage).toBeVisible();
173-
await expect(stockMovementShowPage.informationMessage).toContainText(
174-
'Unable to rollback last receipt in stock movement'
175-
);
180+
await expect(
181+
stockMovementShowPage.rollbackReceiptInformationMessage
182+
).toBeVisible();
183+
await expect(
184+
stockMovementShowPage.rollbackReceiptInformationMessage
185+
).toContainText('Unable to rollback last receipt in stock movement');
176186
await expect(stockMovementShowPage.statusTag).toHaveText('Received');
177187
});
178188
});

0 commit comments

Comments
 (0)