Skip to content

Commit 2cc1e0a

Browse files
authored
Merge pull request #104 from at88mph/resource-fix
Node Resource querying
2 parents bffc9d8 + 1da082c commit 2cc1e0a

File tree

4 files changed

+22
-4
lines changed

4 files changed

+22
-4
lines changed

helm/applications/skaha/Chart.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,13 @@ type: application
2121
# This is the chart version. This version number should be incremented each time you make changes
2222
# to the chart and its templates, including the app version.
2323
# Versions are expected to follow Semantic Versioning (https://semver.org/)
24-
version: 1.1.1
24+
version: 1.1.2
2525

2626
# This is the version number of the application being deployed. This version number should be
2727
# incremented each time you make changes to the application. Versions are not expected to
2828
# follow Semantic Versioning. They should reflect the version the application is using.
2929
# It is recommended to use it with quotes.
30-
appVersion: "1.1.2"
30+
appVersion: "1.1.3"
3131

3232
dependencies:
3333
- name: "redis"

helm/applications/skaha/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,9 @@ A Helm chart to install the Skaha web service of the CANFAR Science Platform
4242
| deployment.skaha.sessions.expirySeconds | string | `"345600"` | |
4343
| deployment.skaha.sessions.imagePullPolicy | string | `"Always"` | |
4444
| deployment.skaha.sessions.initContainerImage | string | `"redis:8.2.2-bookworm"` | |
45+
| deployment.skaha.sessions.nodeLabelSelector | string | `""` | Used to identify Kubernetes Worker Nodes when querying for resources available to User Sessions. |
4546
| deployment.skaha.sessions.kueue | object | `{}` | |
46-
| deployment.skaha.sessions.maxCount | string | `"3"` | |
47+
| deployment.skaha.sessions.maxCount | string | `"5"` | Maximum number of concurrent interactive user sessions. Does not apply to `headless` User Sessions. |
4748
| deployment.skaha.sessions.maxEphemeralStorage | string | `"200Gi"` | |
4849
| deployment.skaha.sessions.minEphemeralStorage | string | `"20Gi"` | |
4950
| deployment.skaha.sessions.persistentVolumeClaimName | string | `"skaha-workload-cavern-pvc"` | |

helm/applications/skaha/templates/skaha-tomcat-deployment.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,10 @@ spec:
7272
- name: SKAHA_HEADLESS_PRIORITY_CLASS
7373
value: "{{ . }}"
7474
{{- end }}
75+
{{- with .Values.deployment.skaha.sessions.nodeLabelSelector }}
76+
- name: SKAHA_WORKER_NODE_LABEL_SELECTOR
77+
value: "{{ . }}"
78+
{{- end }}
7579
{{- with .Values.deployment.skaha.sessions.kueue }}
7680
{{- range $queueConfigKey, $queueConfig := . }}
7781
- name: SKAHA_QUEUE_{{ $queueConfigKey | upper }}_NAME

helm/applications/skaha/values.yaml

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ skahaWorkload:
1515
deployment:
1616
hostname: myhost.example.com # Change this!
1717
skaha:
18-
image: images.opencadc.org/platform/skaha:1.1.2
18+
image: images.opencadc.org/platform/skaha:1.1.3
1919
imagePullPolicy: Always
2020

2121
# Cron string for the image caching cron job schedule. Defaults to every half hour.
@@ -103,6 +103,19 @@ deployment:
103103
# initContainerImage:
104104
initContainerImage: "redis:8.2.2-bookworm"
105105

106+
# Optionally set the node label selector to identify Kubernetes Worker Nodes. This is used to accurately query for available
107+
# resources from schedulable Nodes by eliminating, for example, Nodes that are only cordoned for Web APIs.
108+
# Example:
109+
# nodeLabelSelector: "node-role.kubernetes.io/node-type=worker"
110+
#
111+
# Example (multiple labels ANDed):
112+
# nodeLabelSelector: "node-role.kubernetes.io/node-type=worker,environment=production"
113+
#
114+
#
115+
# Example (multiple labels ORed):
116+
# nodeLabelSelector: "node-role.kubernetes.io/node-type in (worker,worker-gpu)"
117+
nodeLabelSelector:
118+
106119
# Optionally configure the Kueue system to handle large workloads. Configurable per session type (e.g. desktop, notebook, etc.).
107120
# Leaving this empty will default to submitting Jobs to the base Kubernetes system.
108121
# Provide a default configuration for all session types, or omit and only configure specific session types.

0 commit comments

Comments
 (0)