Skip to content

Commit 3657222

Browse files
Merge branch 'solr' into update
Cherry-picking #623
2 parents c4a2248 + 4aae6fc commit 3657222

File tree

3 files changed

+15
-24
lines changed

3 files changed

+15
-24
lines changed

frontend/js/integrations/search.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ define([
8080
data: "id=" + mediaPackageId + "&limit=1",
8181
dataType: "json"
8282
}).then(function (data) {
83-
return data["search-results"].result;
83+
return data.result[0];
8484
});
8585
var mediaPackage = searchResult.then(function (result) {
8686
return result.mediapackage;

opencast-backend/annotation-impl/src/main/java/org/opencast/annotation/impl/persistence/ExtendedAnnotationServiceJpaImpl.java

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -63,12 +63,12 @@
6363
import org.opencastproject.db.DBSession;
6464
import org.opencastproject.db.DBSessionFactory;
6565
import org.opencastproject.mediapackage.MediaPackage;
66-
import org.opencastproject.search.api.SearchQuery;
67-
import org.opencastproject.search.api.SearchResultItem;
6866
import org.opencastproject.search.api.SearchService;
6967
import org.opencastproject.security.api.AuthorizationService;
7068
import org.opencastproject.security.api.SecurityConstants;
7169
import org.opencastproject.security.api.SecurityService;
70+
import org.opencastproject.security.api.UnauthorizedException;
71+
import org.opencastproject.util.NotFoundException;
7272
import org.opencastproject.util.data.Effect;
7373
import org.opencastproject.util.data.Function;
7474
import org.opencastproject.util.data.Function0;
@@ -1169,14 +1169,11 @@ public Boolean none() {
11691169

11701170
@Override
11711171
public Option<MediaPackage> findMediaPackage(String id) {
1172-
return head(searchService.getByQuery(new SearchQuery().withId(id)).getItems()).map(
1173-
new Function<>() {
1174-
@Override
1175-
public MediaPackage apply(SearchResultItem searchResultItem) {
1176-
return searchResultItem.getMediaPackage();
1177-
}
1178-
}
1179-
);
1172+
try {
1173+
return Option.some(searchService.get(id));
1174+
} catch (NotFoundException | UnauthorizedException e) {
1175+
return Option.none();
1176+
}
11801177
}
11811178

11821179
@Override

opencast-backend/annotation-impl/src/test/java/org/opencast/annotation/endpoint/TestRestService.java

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,14 @@
2828
import org.opencast.annotation.impl.persistence.ExtendedAnnotationServiceJpaImpl;
2929

3030
import org.opencastproject.mediapackage.MediaPackage;
31-
import org.opencastproject.search.api.SearchQuery;
32-
import org.opencastproject.search.api.SearchResult;
33-
import org.opencastproject.search.api.SearchResultItem;
3431
import org.opencastproject.search.api.SearchService;
3532
import org.opencastproject.security.api.AuthorizationService;
3633
import org.opencastproject.security.api.DefaultOrganization;
3734
import org.opencastproject.security.api.SecurityService;
35+
import org.opencastproject.security.api.UnauthorizedException;
3836
import org.opencastproject.security.api.User;
3937
import org.opencastproject.security.util.SecurityUtil;
38+
import org.opencastproject.util.NotFoundException;
4039

4140
import org.easymock.EasyMock;
4241
import org.junit.Ignore;
@@ -96,17 +95,12 @@ private static AuthorizationService getAuthorizationService() {
9695
private static SearchService getSearchService() {
9796
MediaPackage mediaPackage = EasyMock.createNiceMock(MediaPackage.class);
9897

99-
SearchResultItem searchResultItem = EasyMock.createNiceMock(SearchResultItem.class);
100-
EasyMock.expect(searchResultItem.getMediaPackage()).andReturn(mediaPackage).anyTimes();
101-
EasyMock.replay(searchResultItem);
102-
103-
SearchResult searchResult = EasyMock.createNiceMock(SearchResult.class);
104-
EasyMock.expect(searchResult.getItems()).andReturn(new SearchResultItem[]{searchResultItem}).anyTimes();
105-
EasyMock.replay(searchResult);
106-
10798
SearchService searchService = EasyMock.createNiceMock(SearchService.class);
108-
EasyMock.expect(searchService.getByQuery(EasyMock.anyObject(SearchQuery.class)))
109-
.andReturn(searchResult).anyTimes();
99+
try {
100+
EasyMock.expect(searchService.get(EasyMock.anyObject(String.class))).andReturn(mediaPackage).anyTimes();
101+
} catch (UnauthorizedException | NotFoundException e) {
102+
// Do nothing. We just have to pretend to handle checked exceptions somehow to appease the compiler.
103+
}
110104
EasyMock.replay(searchService);
111105
return searchService;
112106
}

0 commit comments

Comments
 (0)