Fix clean metadata (#1235)

* fix metadata payload structure for update request

* implement suggested improvements from PR review

* Undo unrelated style changes and remove leftover code

---------

Co-authored-by: Arnei <arnewilken@yahoo.de>

Author: priya-tik

src/utils/resourceUtils.ts

@@ -199,22 +199,28 @@ export const transformListProvider = (collection: { [key: string]: string }) =>
 };
 
 // transform metadata catalog for update via post request
-export const transformMetadataForUpdate = (catalog: MetadataCatalog, values: { [key: string]: MetadataCatalog["fields"][0]["value"] }) => {
+export const transformMetadataForUpdate = (
+	catalog: MetadataCatalog,
+	values: { [key: string]: MetadataCatalog["fields"][0]["value"] },
+) => {
 	const fields: MetadataCatalog["fields"] = [];
-	const updatedFields: MetadataCatalog["fields"] = [];
-
+	const updatedFields: { id: string; value: unknown }[] = [];
 	catalog.fields.forEach(field => {
-		if (field.value !== values[field.id]) {
-			const updatedField = {
-				...field,
-				value: values[field.id],
-			};
-			updatedFields.push(updatedField);
-			fields.push(updatedField);
-		} else {
-			fields.push({ ...field });
+		const newValue = values[field.id];
+
+		// update UI state with full field (optional)
+		const fullField = { ...field, value: newValue };
+		fields.push(fullField);
+
+		// only include minimal clean data for backend if value changed
+		if (field.value !== newValue) {
+			updatedFields.push({
+				id: field.id,
+				value: newValue,
+			});
 		}
 	});
+
 	const data = new URLSearchParams();
 	data.append(
 		"metadata",
@@ -280,7 +286,11 @@ export const prepareMetadataFieldsForPost = (
 };
 
 // returns the name for a field value from the collection
-export const getMetadataCollectionFieldName = (metadataField: { collection?: { [key: string]: unknown }[] }, field: { value: unknown }, t: TFunction): string => {
+export const getMetadataCollectionFieldName = (
+	metadataField: { collection?: { [key: string]: unknown }[] },
+	field: { value: unknown },
+	t: TFunction,
+) => {
 	try {
 		if (metadataField.collection) {
 			const collectionField = metadataField.collection.find(
@@ -306,8 +316,8 @@ export const getMetadataCollectionFieldName = (metadataField: { collection?: { [
 // Prepare rules of access policies for post of new events or series
 export const prepareAccessPolicyRulesForPost = (policies: TransformedAcl[]) => {
 	// access policies for post request
-	const access : {
-		acl : Acl
+	const access: {
+		acl: Acl
 	} = {
 		acl: {
 			ace: [],