processed feedback on PR #28

Author: basvanbeek

dbstats_go1.11.go

@@ -5,6 +5,7 @@ package ocsql
 import (
 	"context"
 	"database/sql"
+	"sync"
 	"time"
 
 	"go.opencensus.io/stats"
@@ -14,9 +15,10 @@ import (
 // interval.
 func RecordStats(db *sql.DB, interval time.Duration) (fnStop func()) {
 	var (
-		ctx    = context.Background()
-		ticker = time.NewTicker(interval)
-		done   = make(chan struct{})
+		closeOnce sync.Once
+		ctx       = context.Background()
+		ticker    = time.NewTicker(interval)
+		done      = make(chan struct{})
 	)
 
 	go func() {
@@ -41,6 +43,8 @@ func RecordStats(db *sql.DB, interval time.Duration) (fnStop func()) {
 	}()
 
 	return func() {
-		close(done)
+		closeOnce.Do(func() {
+			close(done)
+		})
 	}
 }

observability.go

@@ -159,7 +159,7 @@ func recordCallStats(ctx context.Context, method string) func(err error) {
 	startTime := time.Now()
 
 	return func(err error) {
-		timeSpent := float64(time.Since(startTime).Nanoseconds()) / 1e6
+		timeSpentMs := float64(time.Since(startTime).Nanoseconds()) / 1e6
 
 		if err != nil {
 			tags = []tag.Mutator{
@@ -171,6 +171,6 @@ func recordCallStats(ctx context.Context, method string) func(err error) {
 			}
 		}
 
-		_ = stats.RecordWithTags(ctx, tags, MeasureLatencyMs.M(timeSpent))
+		_ = stats.RecordWithTags(ctx, tags, MeasureLatencyMs.M(timeSpentMs))
 	}
 }