removed transaction-span trace option as tx begin context is not propagated to exec calls

Author: basvanbeek

driver.go

@@ -334,16 +334,6 @@ func (c *ocConn) BeginTx(ctx context.Context, opts driver.TxOptions) (driver.Tx,
 		return c.parent.Begin()
 	}
 
-	if c.options.Transaction {
-		if ctx == nil || ctx == context.TODO() {
-			var appSpan *trace.Span
-			ctx, appSpan = trace.StartSpan(context.Background(), "sql:transaction")
-			appSpan.AddAttributes(attrMissingContext)
-		} else {
-			ctx, _ = trace.StartSpan(ctx, "sql:transaction")
-		}
-	}
-
 	var span *trace.Span
 	if ctx == nil || ctx == context.TODO() {
 		ctx = context.Background()
@@ -612,16 +602,6 @@ type ocTx struct {
 }
 
 func (t ocTx) Commit() (err error) {
-	if t.options.Transaction {
-		defer func() {
-			if span := trace.FromContext(t.ctx); span != nil {
-				span.SetStatus(trace.Status{Code: trace.StatusCodeOK})
-				setSpanStatus(span, err)
-				span.End()
-			}
-		}()
-	}
-
 	_, span := trace.StartSpan(t.ctx, "sql:commit")
 	defer func() {
 		setSpanStatus(span, err)
@@ -633,22 +613,6 @@ func (t ocTx) Commit() (err error) {
 }
 
 func (t ocTx) Rollback() (err error) {
-	if t.options.Transaction {
-		defer func() {
-			if span := trace.FromContext(t.ctx); span != nil {
-				if err == nil {
-					span.SetStatus(trace.Status{
-						Code:    trace.StatusCodeAborted,
-						Message: "transaction rollback",
-					})
-				} else {
-					setSpanStatus(span, err)
-				}
-				span.End()
-			}
-		}()
-	}
-
 	_, span := trace.StartSpan(t.ctx, "sql:rollback")
 	defer func() {
 		setSpanStatus(span, err)

options.go

@@ -14,11 +14,6 @@ type TraceOptions struct {
 	// in context or when using methods not taking context.
 	AllowRoot bool
 
-	// Transaction, if set to true, will create spans for the duration of db
-	// transactions. All spans created by the transaction's scoped queries will
-	// become children of the transaction span.
-	Transaction bool
-
 	// Ping, if set to true, will enable the creation of spans on Ping requests.
 	Ping bool
 
@@ -60,7 +55,6 @@ func WithAllTraceOptions() TraceOption {
 // AllTraceOptions has all tracing options enabled.
 var AllTraceOptions = TraceOptions{
 	AllowRoot:    true,
-	Transaction:  true,
 	Ping:         true,
 	RowsNext:     true,
 	RowsClose:    true,
@@ -88,15 +82,6 @@ func WithAllowRoot(b bool) TraceOption {
 	}
 }
 
-// WithTransaction if set to true, will create spans for the duration of db
-// transactions. All spans created by the transaction's scoped queries will
-// become children of the transaction span.
-func WithTransaction(b bool) TraceOption {
-	return func(o *TraceOptions) {
-		o.Transaction = b
-	}
-}
-
 // WithPing if set to true, will enable the creation of spans on Ping requests.
 func WithPing(b bool) TraceOption {
 	return func(o *TraceOptions) {