API: always return bad request if media submission fails

webprofusion-chrisc · webprofusion-chrisc · commit e9660f5ccac4 · 2026-02-03T08:37:45.000+08:00
diff --git a/API/OCM.Net/OCM.API.Web/Compatibility/CompatibilityAPIHandler.cs b/API/OCM.Net/OCM.API.Web/Compatibility/CompatibilityAPIHandler.cs
@@ -350,19 +350,14 @@ private async Task<bool> PerformInput(HttpContext context)
                         {
                             await context.Response.WriteAsync("OK");
                         }
+                        return true;
                     }
                     else
                     {
-                        if (filter.APIVersion >= 3)
-                        {
-                            await OutputBadRequestMessage(context, "Failed");
-                        }
-                        else
-                        {
-                            await context.Response.WriteAsync("Error");
-                        }
+                        await OutputBadRequestMessage(context, "Failed");
+                        return false;
                     }
-                    return true;
+
                 }
             }
 

Original file line number	Diff line number	Diff line change
`@@ -350,19 +350,14 @@ private async Task<bool> PerformInput(HttpContext context)`
`350`	`350`	`{`
`351`	`351`	`await context.Response.WriteAsync("OK");`
`352`	`352`	`}`
	`353`	`+ return true;`
`353`	`354`	`}`
`354`	`355`	`else`
`355`	`356`	`{`
`356`		`- if (filter.APIVersion >= 3)`
`357`		`- {`
`358`		`- await OutputBadRequestMessage(context, "Failed");`
`359`		`- }`
`360`		`- else`
`361`		`- {`
`362`		`- await context.Response.WriteAsync("Error");`
`363`		`- }`
	`357`	`+ await OutputBadRequestMessage(context, "Failed");`
	`358`	`+ return false;`
`364`	`359`	`}`
`365`		`- return true;`
	`360`	`+`
`366`	`361`	`}`
`367`	`362`	`}`
`368`	`363`