fix: internalize download counter mutations

Author: steipete

convex/downloads.ts

@@ -1,6 +1,6 @@
 import { v } from 'convex/values'
 import { api, internal } from './_generated/api'
-import { httpAction, internalMutation, mutation } from './functions'
+import { httpAction, internalMutation } from './functions'
 import { getOptionalApiTokenUserId } from './lib/apiTokenAuth'
 import { applyRateLimit, getClientIp } from './lib/httpRateLimit'
 import { corsHeaders, mergeHeaders } from './lib/httpHeaders'
@@ -145,19 +145,6 @@ export const downloadZip = httpAction(async (ctx, request) => {
   })
 })
 
-export const increment = mutation({
-  args: { skillId: v.id('skills') },
-  handler: async (ctx, args) => {
-    // Skip db.get to avoid adding the skill doc to the read set.
-    // The calling HTTP action already validated the skill exists,
-    // and the stat processor handles deleted skills gracefully.
-    await insertStatEvent(ctx, {
-      skillId: args.skillId,
-      kind: 'download',
-    })
-  },
-})
-
 export const recordDownloadInternal = internalMutation({
   args: {
     skillId: v.id('skills'),

convex/httpApiV1.handlers.test.ts

@@ -1,5 +1,6 @@
 /* @vitest-environment node */
 import { beforeEach, describe, expect, it, vi } from 'vitest'
+import { internal } from './_generated/api'
 
 vi.mock('./lib/apiTokenAuth', () => ({
   requireApiTokenUser: vi.fn(),
@@ -634,6 +635,9 @@ describe('httpApiV1 handlers', () => {
     expect(response.status).toBe(200)
     expect(await response.text()).toBe('hello')
     expect(storageGet).toHaveBeenCalledWith('_storage:1')
+    expect(runMutation).toHaveBeenCalledWith(internal.soulDownloads.incrementInternal, {
+      soulId: 'souls:1',
+    })
   })
 
   it('lists skills supports sort aliases', async () => {

convex/httpApiV1/soulsV1.ts

@@ -265,7 +265,7 @@ export async function soulsGetRouterV1Handler(ctx: ActionCtx, request: Request)
     if (!blob) return text('File missing in storage', 410, rate.headers)
     const textContent = await blob.text()
 
-    void ctx.runMutation(api.soulDownloads.increment, { soulId: soul._id })
+    void ctx.runMutation(internal.soulDownloads.incrementInternal, { soulId: soul._id })
     return safeTextFileResponse({
       textContent,
       path: file.path,

convex/soulDownloads.ts

@@ -1,7 +1,7 @@
 import { v } from 'convex/values'
-import { mutation } from './functions'
+import { internalMutation } from './functions'
 
-export const increment = mutation({
+export const incrementInternal = internalMutation({
   args: { soulId: v.id('souls') },
   handler: async (ctx, args) => {
     const soul = await ctx.db.get(args.soulId)