fix: address deploy typecheck

Author: steipete

convex/httpApiV1.handlers.test.ts

@@ -38,18 +38,6 @@ beforeEach(() => {
   vi.mocked(publishVersionForUser).mockReset()
 })
 
-if (typeof File === 'undefined') {
-  class NodeFile extends Blob {
-    name: string
-    constructor(parts: BlobPart[], name: string, options?: BlobPropertyBag) {
-      super(parts, options)
-      this.name = name
-    }
-  }
-  const globalFile = globalThis as typeof globalThis & { File?: typeof File }
-  globalFile.File = NodeFile
-}
-
 describe('httpApiV1 handlers', () => {
   it('search returns empty results for blank query', async () => {
     const runAction = vi.fn()
@@ -425,7 +413,7 @@ describe('httpApiV1 handlers', () => {
         tags: ['latest'],
       }),
     )
-    form.append('files', new File(['hello'], 'SKILL.md', { type: 'text/plain' }))
+    form.append('files', new Blob(['hello'], { type: 'text/plain' }), 'SKILL.md')
     const response = await __handlers.publishSkillV1Handler(
       makeCtx({ runMutation, storage: { store: vi.fn().mockResolvedValue('storage:1') } }),
       new Request('https://example.com/api/v1/skills', {

convex/httpApiV1.ts

@@ -375,16 +375,15 @@ type FileLike = {
   arrayBuffer: () => Promise<ArrayBuffer>
 }
 
-function isFileLike(entry: FormDataEntryValue): entry is FileLike {
-  if (typeof entry === 'string') return false
-  if (typeof File !== 'undefined' && entry instanceof File) return true
+type FileLikeEntry = FormDataEntryValue & FileLike
+
+function toFileLike(entry: FormDataEntryValue): FileLikeEntry | null {
+  if (typeof entry === 'string') return null
   const candidate = entry as Partial<FileLike>
-  return (
-    typeof candidate.name === 'string' &&
-    typeof candidate.size === 'number' &&
-    typeof candidate.type === 'string' &&
-    typeof candidate.arrayBuffer === 'function'
-  )
+  if (typeof candidate.name !== 'string') return null
+  if (typeof candidate.size !== 'number') return null
+  if (typeof candidate.arrayBuffer !== 'function') return null
+  return entry as FileLikeEntry
 }
 
 async function skillsPostRouterV1Handler(ctx: ActionCtx, request: Request) {
@@ -496,13 +495,14 @@ async function parseMultipartPublish(
   }> = []
 
   for (const entry of form.getAll('files')) {
-    if (!isFileLike(entry)) continue
-    const path = entry.name
-    const size = entry.size
-    const contentType = entry.type || undefined
-    const buffer = new Uint8Array(await entry.arrayBuffer())
+    const file = toFileLike(entry)
+    if (!file) continue
+    const path = file.name
+    const size = file.size
+    const contentType = file.type || undefined
+    const buffer = new Uint8Array(await file.arrayBuffer())
     const sha256 = await sha256Hex(buffer)
-    const storageId = await ctx.storage.store(entry)
+    const storageId = await ctx.storage.store(file as Blob)
     files.push({ path, size, storageId, sha256, contentType })
   }
 
@@ -685,8 +685,8 @@ function toOptionalNumber(value: string | null) {
 }
 
 async function sha256Hex(bytes: Uint8Array) {
-  const buffer = bytes.buffer.slice(bytes.byteOffset, bytes.byteOffset + bytes.byteLength)
-  const digest = await crypto.subtle.digest('SHA-256', buffer)
+  const normalized = new Uint8Array(bytes)
+  const digest = await crypto.subtle.digest('SHA-256', normalized.buffer)
   return toHex(new Uint8Array(digest))
 }
 

e2e/clawdhub.e2e.test.ts

@@ -319,7 +319,8 @@ describe('clawdhub e2e', () => {
       )
       expect(update.status).toBe(0)
 
-      const metaRes = await fetch(`${registry}${ApiRoutes.skills}/${slug}`, {
+      const metaUrl = new URL(`${ApiRoutes.skills}/${slug}`, registry)
+      const metaRes = await fetch(metaUrl.toString(), {
         headers: { Accept: 'application/json' },
       })
       expect(metaRes.status).toBe(200)

src/components/Header.tsx

@@ -63,7 +63,9 @@ export default function Header() {
           >
             Skills
           </Link>
-          <Link to="/upload">Upload</Link>
+          <Link to="/upload" search={{ updateSlug: undefined }}>
+            Upload
+          </Link>
           <Link to="/search" search={{ q: undefined, highlighted: undefined }}>
             Search
           </Link>
@@ -94,7 +96,9 @@ export default function Header() {
                   </Link>
                 </DropdownMenuItem>
                 <DropdownMenuItem asChild>
-                  <Link to="/upload">Upload</Link>
+                  <Link to="/upload" search={{ updateSlug: undefined }}>
+                    Upload
+                  </Link>
                 </DropdownMenuItem>
                 <DropdownMenuItem asChild>
                   <Link to="/search" search={{ q: undefined, highlighted: undefined }}>

src/routes/dashboard.tsx

@@ -29,7 +29,7 @@ function Dashboard() {
         <h1 className="section-title" style={{ margin: 0 }}>
           My Skills
         </h1>
-        <Link to="/upload" className="btn btn-primary">
+        <Link to="/upload" search={{ updateSlug: undefined }} className="btn btn-primary">
           <Plus className="h-4 w-4" aria-hidden="true" />
           Upload New Skill
         </Link>
@@ -40,7 +40,7 @@ function Dashboard() {
           <Package className="dashboard-empty-icon" aria-hidden="true" />
           <h2>No skills yet</h2>
           <p>Upload your first skill to share it with the community.</p>
-          <Link to="/upload" className="btn btn-primary">
+          <Link to="/upload" search={{ updateSlug: undefined }} className="btn btn-primary">
             <Upload className="h-4 w-4" aria-hidden="true" />
             Upload a Skill
           </Link>

src/routes/index.tsx

@@ -93,7 +93,7 @@ function Home() {
               vectors. No gatekeeping, just signal.
             </p>
             <div style={{ display: 'flex', gap: 12, marginTop: 20 }}>
-              <Link to="/upload" className="btn btn-primary">
+              <Link to="/upload" search={{ updateSlug: undefined }} className="btn btn-primary">
                 Publish a skill
               </Link>
               <Link to="/search" search={{ q: undefined, highlighted: undefined }} className="btn">