Fix incorrect reuse of input solar features (#200)

naman9271 · web-flow · commit 38d12f34d5e6 · 2026-01-12T10:54:55.000Z
diff --git a/.gitignore b/.gitignore
@@ -11,3 +11,4 @@ checkpoints/
 lightning_logs/
 pixi.lock
 .python-version
+.venv/
diff --git a/graph_weather/data/dataloader.py b/graph_weather/data/dataloader.py
@@ -117,7 +117,7 @@ def __getitem__(self, item):
             end_solar_times.append(
                 np.array([extraterrestrial_irrad(when, lat, lon) for lat, lon in lat_lons])
             )
-        end_solar_times = np.array(solar_times)
+        end_solar_times = np.array(end_solar_times)
 
         # Normalize to between -1 and 1
         solar_times -= const.SOLAR_MEAN

Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ def __getitem__(self, item):`
`117`	`117`	`end_solar_times.append(`
`118`	`118`	`np.array([extraterrestrial_irrad(when, lat, lon) for lat, lon in lat_lons])`
`119`	`119`	`)`
`120`		`- end_solar_times = np.array(solar_times)`
	`120`	`+ end_solar_times = np.array(end_solar_times)`
`121`	`121`
`122`	`122`	`# Normalize to between -1 and 1`
`123`	`123`	`solar_times -= const.SOLAR_MEAN`