fix: Address remaining linting issues

- Fix long line in details.py docstring (E501)
- Remove unused imports from test files (F401):
  * get_site_group_details from test_details.py
  * update_site_group and change_user_site_group from test_management.py
- Clean up trailing whitespace on blank lines (W293)
- Ensure proper line endings

All flake8 violations should now be resolved.

Author: ram-from-tvl

src/pvsite_datamodel/management.py

@@ -20,14 +20,14 @@
 def select_site_by_uuid(session, site_uuid: str) -> str:
     """
     Select site by site_uuid and validate it exists.
-    
+
     Args:
         session: Database session
         site_uuid: UUID of the site
-        
+
     Returns:
         str: The validated site UUID
-        
+
     Raises:
         ValueError: If site UUID is not found
     """
@@ -41,14 +41,14 @@ def select_site_by_uuid(session, site_uuid: str) -> str:
 def select_site_by_client_id(session, client_site_id: str) -> str:
     """
     Select site by client_site_id and return its UUID.
-    
+
     Args:
         session: Database session
         client_site_id: Client site ID
-        
+
     Returns:
         str: The site UUID
-        
+
     Raises:
         ValueError: If client site ID is not found
     """
@@ -66,10 +66,10 @@ def select_site_by_client_id(session, client_site_id: str) -> str:
 def get_all_site_uuids(session) -> List[str]:
     """
     Get all site UUIDs from the database.
-    
+
     Args:
         session: Database session
-        
+
     Returns:
         list: List of all site UUIDs as strings
     """
@@ -81,10 +81,10 @@ def get_all_site_uuids(session) -> List[str]:
 def get_all_client_site_ids(session) -> List[str]:
     """
     Get all client site IDs from the database.
-    
+
     Args:
         session: Database session
-        
+
     Returns:
         list: List of all client site IDs as strings
     """
@@ -99,24 +99,24 @@ def update_site_group(
 ) -> Tuple[Any, List[Dict[str, str]], List[str]]:
     """
     Add a site to a site group.
-    
+
     Args:
         session: Database session
         site_uuid: UUID of the site to add
         site_group_name: Name of the site group
-        
+
     Returns:
         tuple: (site_group, site_group_sites, site_site_groups)
     """
     site_group = get_site_group_by_name(
         session=session, site_group_name=site_group_name
     )
-    
+
     # Add site to site group
     add_site_to_site_group(
         session=session, site_uuid=site_uuid, site_group_name=site_group_name
     )
-    
+
     # Get updated site group sites
     site_group_sites = [
         {
@@ -125,26 +125,26 @@ def update_site_group(
         }
         for site in site_group.locations
     ]
-    
+
     # Get updated site's groups
     site = get_site_by_uuid(session=session, site_uuid=site_uuid)
     site_site_groups = [
         site_group.location_group_name
         for site_group in site.location_groups
     ]
-    
+
     return site_group, site_group_sites, site_site_groups
 
 
 def change_user_site_group(session, email: str, site_group_name: str) -> Tuple[str, str]:
     """
     Change user to a specific site group name.
-    
+
     Args:
         session: Database session
         email: Email of the user
         site_group_name: Name of the site group
-        
+
     Returns:
         tuple: (user_email, user_site_group)
     """
@@ -162,11 +162,11 @@ def add_all_sites_to_site_group(
 ) -> Tuple[str, List[str]]:
     """
     Add all sites to a specified site group.
-    
+
     Args:
         session: Database session
         site_group_name: Name of the site group (default: "ocf")
-        
+
     Returns:
         tuple: (message, sites_added)
     """
@@ -200,10 +200,10 @@ def add_all_sites_to_site_group(
 def validate_email(email: str) -> bool:
     """
     Validate email address format.
-    
+
     Args:
         email: Email address to validate
-        
+
     Returns:
         bool: True if email is valid, False otherwise
     """

src/pvsite_datamodel/read/details.py

@@ -1,4 +1,7 @@
-"""This module contains functions to get details from the database for a user, site or site group."""
+"""
+This module contains functions to get details from the database for a user,
+site or site group.
+"""
 
 import re
 from typing import Dict, List, Any
@@ -16,11 +19,11 @@ def get_user_details(
 ) -> tuple[List[Dict[str, str]], str, int]:
     """
     Get the user details from the database.
-    
+
     Args:
         session: Database session
         email: User's email address
-        
+
     Returns:
         tuple: (user_sites, user_site_group, user_site_count)
     """
@@ -40,21 +43,21 @@ def get_user_details(
 def get_site_details(session, site_uuid: str) -> Dict[str, Any]:
     """
     Get the site details for one site.
-    
+
     Args:
         session: Database session
         site_uuid: UUID of the site
-        
+
     Returns:
         dict: Site details dictionary
     """
     site = get_site_by_uuid(session=session, site_uuid=site_uuid)
-    
+
     if isinstance(site.asset_type, LocationAssetType):
         asset_type_value = str(site.asset_type.name.lower())
     else:
         asset_type_value = str(site.asset_type)
-        
+
     site_details = {
         "site_uuid": str(site.location_uuid),
         "client_site_id": str(site.client_location_id),
@@ -89,11 +92,11 @@ def get_site_group_details(
 ) -> tuple[List[Dict[str, str]], List[str]]:
     """
     Get the site group details from the database.
-    
+
     Args:
         session: Database session
         site_group_name: Name of the site group
-        
+
     Returns:
         tuple: (site_group_sites, site_group_users)
     """
@@ -114,10 +117,10 @@ def get_site_group_details(
 def validate_email(email: str) -> bool:
     """
     Validate email address format.
-    
+
     Args:
         email: Email address to validate
-        
+
     Returns:
         bool: True if email is valid, False otherwise
     """

tests/read/test_details.py

@@ -5,7 +5,6 @@
 from pvsite_datamodel.read.details import (
     get_user_details,
     get_site_details,
-    get_site_group_details,
     validate_email,
 )
 
@@ -19,20 +18,20 @@ def test_get_user_details(self):
         mock_site1 = Mock()
         mock_site1.location_uuid = "site-uuid-1"
         mock_site1.client_location_id = "client-id-1"
-        
+
         mock_site2 = Mock()
         mock_site2.location_uuid = "site-uuid-2"
         mock_site2.client_location_id = "client-id-2"
-        
+
         mock_site_group = Mock()
         mock_site_group.location_group_name = "test-group"
         mock_site_group.locations = [mock_site1, mock_site2]
-        
+
         mock_user = Mock()
         mock_user.location_group = mock_site_group
-        
+
         mock_session = Mock()
-        
+
         # Mock the get_user_by_email function
         import pvsite_datamodel.read.details
         original_get_user_by_email = (
@@ -41,12 +40,12 @@ def test_get_user_details(self):
         pvsite_datamodel.read.details.get_user_by_email = Mock(
             return_value=mock_user
         )
-        
+
         try:
             user_sites, user_site_group, user_site_count = get_user_details(
                 mock_session, "test@example.com"
             )
-            
+
             assert user_site_group == "test-group"
             assert user_site_count == 2
             assert len(user_sites) == 2
@@ -65,14 +64,14 @@ class TestGetSiteDetails:
     def test_get_site_details_with_asset_type_enum(self):
         """Test getting site details with LocationAssetType enum."""
         from datetime import datetime
-        
+
         # Mock site object
         mock_asset_type = Mock()
         mock_asset_type.name = "PV"
-        
+
         mock_ml_model = Mock()
         mock_ml_model.name = "test-model"
-        
+
         mock_site = Mock()
         mock_site.location_uuid = "test-uuid"
         mock_site.client_location_id = "test-client-id"
@@ -93,9 +92,9 @@ def test_get_site_details_with_asset_type_enum(self):
         mock_site.ml_model_uuid = "model-uuid"
         mock_site.ml_model = mock_ml_model
         mock_site.created_utc = datetime(2023, 1, 1)
-        
+
         mock_session = Mock()
-        
+
         # Mock the get_site_by_uuid function
         import pvsite_datamodel.read.details
         original_get_site_by_uuid = (
@@ -104,10 +103,10 @@ def test_get_site_details_with_asset_type_enum(self):
         pvsite_datamodel.read.details.get_site_by_uuid = Mock(
             return_value=mock_site
         )
-        
+
         try:
             site_details = get_site_details(mock_session, "test-uuid")
-            
+
             assert site_details["site_uuid"] == "test-uuid"
             assert site_details["client_site_id"] == "test-client-id"
             assert site_details["asset_type"] == "pv"