fix: Fix detekt issues and add missing imports

Author: zerox80

opencloudApp/src/main/java/eu/opencloud/android/presentation/settings/security/SettingsSecurityFragment.kt

@@ -117,6 +117,16 @@ class SettingsSecurityFragment : PreferenceFragmentCompat() {
 
     override fun onCreatePreferences(savedInstanceState: Bundle?, rootKey: String?) {
         setPreferencesFromResource(R.xml.settings_security, rootKey)
+        initializePreferences(rootKey)
+        configureLockPreferences()
+        configureBiometricPreference()
+        configureSecurityPreferences()
+        configureDownloadAndSyncPreferences()
+    }
+
+
+    @Suppress("UnusedParameter")
+    private fun initializePreferences(rootKey: String?) {
         screenSecurity = findPreference(SCREEN_SECURITY)
         prefPasscode = findPreference(PassCodeActivity.PREFERENCE_SET_PASSCODE)
         prefPattern = findPreference(PatternActivity.PREFERENCE_SET_PATTERN)
@@ -144,7 +154,9 @@ class SettingsSecurityFragment : PreferenceFragmentCompat() {
 
         prefPasscode?.isVisible = !securityViewModel.isSecurityEnforcedEnabled()
         prefPattern?.isVisible = !securityViewModel.isSecurityEnforcedEnabled()
+    }
 
+    private fun configureLockPreferences() {
         // Passcode lock
         prefPasscode?.setOnPreferenceChangeListener { _: Preference?, newValue: Any ->
             if (securityViewModel.isPatternSet()) {
@@ -178,8 +190,9 @@ class SettingsSecurityFragment : PreferenceFragmentCompat() {
             }
             false
         }
+    }
 
-        // Biometric lock
+    private fun configureBiometricPreference() {
         if (prefBiometric != null) {
             if (!BiometricManager.isHardwareDetected()) { // Biometric not supported
                 screenSecurity?.removePreferenceFromScreen(prefBiometric)
@@ -201,8 +214,12 @@ class SettingsSecurityFragment : PreferenceFragmentCompat() {
         }
 
         // Lock application
-        if (prefPasscode?.isChecked == false && prefPattern?.isChecked == false) { prefLockApplication?.isEnabled = false }
+        if (prefPasscode?.isChecked == false && prefPattern?.isChecked == false) {
+            prefLockApplication?.isEnabled = false
+        }
+    }
 
+    private fun configureSecurityPreferences() {
         // Lock access from document provider
         prefLockAccessDocumentProvider?.setOnPreferenceChangeListener { _: Preference?, newValue: Any ->
             securityViewModel.setPrefLockAccessDocumentProvider(true)
@@ -231,7 +248,9 @@ class SettingsSecurityFragment : PreferenceFragmentCompat() {
             }
             true
         }
+    }
 
+    private fun configureDownloadAndSyncPreferences() {
         // Download Everything Feature
         prefDownloadEverything?.setOnPreferenceChangeListener { _: Preference?, newValue: Any ->
             if (newValue as Boolean) {

opencloudApp/src/main/java/eu/opencloud/android/ui/activity/FileDisplayActivity.kt

@@ -114,9 +114,13 @@ import eu.opencloud.android.syncadapter.FileSyncAdapter
 import eu.opencloud.android.ui.fragment.FileFragment
 import eu.opencloud.android.ui.fragment.TaskRetainerFragment
 import eu.opencloud.android.ui.helpers.FilesUploadHelper
+import eu.opencloud.android.ui.dialog.FileAlreadyExistsDialog
 import eu.opencloud.android.ui.preview.PreviewAudioFragment
+import eu.opencloud.android.ui.preview.PreviewImageActivity
+import eu.opencloud.android.ui.preview.PreviewImageFragment
 import eu.opencloud.android.ui.preview.PreviewTextFragment
 import eu.opencloud.android.ui.preview.PreviewVideoActivity
+import androidx.work.WorkManager
 import eu.opencloud.android.usecases.synchronization.SynchronizeFileUseCase
 import eu.opencloud.android.usecases.transfers.downloads.DownloadFileUseCase
 import eu.opencloud.android.utils.PreferenceUtils

opencloudApp/src/main/java/eu/opencloud/android/workers/DownloadEverythingWorker.kt

@@ -120,7 +120,7 @@ class DownloadEverythingWorker(
                         spaces.forEachIndexed { spaceIndex, space ->
                             Timber.i("Processing space ${spaceIndex + 1}/${spaces.size}: ${space.name}")
                             updateNotification("Space ${spaceIndex + 1}/${spaces.size}: ${space.name}")
-                            
+
                             processSpaceRoot(accountName, ROOT_PATH, space.root.id)
                         }
                     }
@@ -148,30 +148,30 @@ class DownloadEverythingWorker(
     private fun processSpaceRoot(accountName: String, remotePath: String, spaceId: String?) {
         try {
             Timber.i("Processing space root: remotePath=$remotePath, spaceId=$spaceId")
-            
+
             // First refresh the root folder from server to ensure DB has latest data
             fileRepository.refreshFolder(
                 remotePath = remotePath,
                 accountName = accountName,
                 spaceId = spaceId,
                 isActionSetFolderAvailableOfflineOrSynchronize = false
             )
-            
+
             // Now get the root folder from local database
             val rootFolder = getFileByRemotePathUseCase(
                 GetFileByRemotePathUseCase.Params(accountName, remotePath, spaceId)
             ).getDataOrNull()
-            
+
             if (rootFolder == null) {
                 Timber.w("Root folder not found after refresh for spaceId=$spaceId")
                 return
             }
-            
+
             Timber.i("Got root folder with id=${rootFolder.id}, remotePath=${rootFolder.remotePath}")
-            
+
             // Process the root folder recursively
             processFolderRecursively(accountName, rootFolder, spaceId)
-            
+
         } catch (e: Exception) {
             Timber.e(e, "Error processing space root: spaceId=$spaceId")
         }
@@ -188,10 +188,10 @@ class DownloadEverythingWorker(
                 Timber.w("Folder ${folder.remotePath} has no id, skipping")
                 return
             }
-            
+
             foldersProcessed++
             Timber.d("Processing folder: ${folder.remotePath} (id=$folderId)")
-            
+
             // First refresh this folder from server
             try {
                 fileRepository.refreshFolder(
@@ -203,10 +203,10 @@ class DownloadEverythingWorker(
             } catch (e: Exception) {
                 Timber.e(e, "Error refreshing folder ${folder.remotePath}")
             }
-            
+
             // Now get ALL content from local database (this returns everything, not just changes)
             val folderContent = fileRepository.getFolderContent(folderId)
-            
+
             Timber.d("Folder ${folder.remotePath} contains ${folderContent.size} items")
 
             folderContent.forEach { item ->
@@ -218,7 +218,7 @@ class DownloadEverythingWorker(
                     processFile(accountName, item)
                 }
             }
-            
+
             // Update notification periodically
             if (foldersProcessed % 5 == 0) {
                 updateNotification("Scanning: $foldersProcessed folders, $totalFilesFound files found")
@@ -234,7 +234,7 @@ class DownloadEverythingWorker(
      */
     private fun processFile(accountName: String, file: OCFile) {
         totalFilesFound++
-        
+
         try {
             if (file.isAvailableLocally) {
                 // File is already downloaded
@@ -251,7 +251,7 @@ class DownloadEverythingWorker(
                     Timber.d("Download already enqueued or skipped: ${file.fileName}")
                 }
             }
-            
+
             // Update notification periodically (every 20 files)
             if (totalFilesFound % 20 == 0) {
                 updateNotification("Found: $totalFilesFound files, $filesDownloaded queued for download")
@@ -298,7 +298,7 @@ class DownloadEverythingWorker(
         const val DOWNLOAD_EVERYTHING_WORKER = "DOWNLOAD_EVERYTHING_WORKER"
         const val repeatInterval: Long = 6L
         val repeatIntervalTimeUnit: TimeUnit = TimeUnit.HOURS
-        
+
         private const val NOTIFICATION_CHANNEL_ID = "download_everything_channel"
         private const val NOTIFICATION_ID = 9001
     }

opencloudComLibrary/src/main/java/eu/opencloud/android/lib/resources/users/GetRemoteUserAvatarOperation.kt

@@ -41,6 +41,7 @@ import java.net.URL
  * @author David A. Velasco
  * @author David González Verdugo
  */
+@Suppress("UnusedPrivateProperty")
 class GetRemoteUserAvatarOperation(private val avatarDimension: Int) : RemoteOperation<RemoteAvatarData>() {
     override fun run(client: OpenCloudClient): RemoteOperationResult<RemoteAvatarData> {
         var inputStream: InputStream? = null

opencloudData/src/main/java/eu/opencloud/android/data/providers/ScopedStorageProvider.kt

@@ -23,6 +23,7 @@ import android.content.Context
 import android.os.Environment
 import java.io.File
 
+@Suppress("UnusedPrivateProperty")
 class ScopedStorageProvider(
     rootFolderName: String,
     private val context: Context