Skip to content

Commit 837afd2

Browse files
authored
Fix sorting in spaces view may crash the application (#255)
1 parent 9f829e9 commit 837afd2

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

packages/web-app-files/src/views/spaces/Projects.vue

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,6 @@ import {
165165
useSpacesStore,
166166
useExtensionRegistry,
167167
ItemFilterToggle,
168-
useRouteQuery,
169168
queryItemAsString,
170169
useLoadPreview
171170
} from '@opencloud-eu/web-pkg'
@@ -235,7 +234,6 @@ export default defineComponent({
235234
const { $gettext } = language
236235
const filterTerm = ref('')
237236
const markInstance = ref(undefined)
238-
const includeDisabledParam = useRouteQuery('q_includeDisabled')
239237
const resourcesStore = useResourcesStore()
240238
241239
const { setSelection, initResourceList, clearResourceList, setAncestorMetaData } =
@@ -310,13 +308,13 @@ export default defineComponent({
310308
const searchEngine = new Fuse(spaces, { ...defaultFuseOptions, keys: ['name'] })
311309
return searchEngine.search(filterTerm).map((r) => r.item)
312310
}
313-
const items = computed(() =>
314-
orderBy(
311+
const items = computed(() => {
312+
return orderBy(
315313
filter(unref(spaces), unref(filterTerm)),
316-
[(item: SpaceResource) => item[unref(sortBy)].toLowerCase()],
314+
[(item: SpaceResource) => typeof item[unref(sortBy)] === 'string' ? item[unref(sortBy)].toLowerCase() : item[unref(sortBy)]],
317315
unref(sortDir)
318316
)
319-
)
317+
})
320318
321319
const {
322320
items: paginatedItems,

packages/web-client/src/helpers/space/functions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ export function buildSpace(
187187
type: 'space',
188188
isFolder: true,
189189
mdate: data.lastModifiedDateTime,
190-
size: data.quota?.used,
190+
size: data.quota?.used || 0,
191191
indicators: [] as ResourceIndicator[],
192192
tags: [] as string[],
193193
permissions: '',

0 commit comments

Comments
 (0)