fix: get status_code for http exceptions (#5)

Author: enicioli

src/Middleware/MetricMiddleware.php

@@ -11,6 +11,7 @@
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
 use Psr\Http\Server\RequestHandlerInterface;
+use Swoole\Http\Status;
 use Throwable;
 
 class MetricMiddleware extends AbstractMiddleware
@@ -41,7 +42,7 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface
             return $response;
         } catch (Throwable $exception) {
             $attributes[ErrorAttributes::ERROR_TYPE] = get_class($exception);
-            $attributes[HttpAttributes::HTTP_RESPONSE_STATUS_CODE] = 500;
+            $attributes[HttpAttributes::HTTP_RESPONSE_STATUS_CODE] = $this->getHttpStatusCodeForException($exception);
 
             throw $exception;
         } finally {
@@ -57,4 +58,12 @@ protected function featureName(): string
     {
         return 'client_request';
     }
+
+    protected function getHttpStatusCodeForException(Throwable $exception): int
+    {
+        $exceptionCode = $exception->getCode();
+        $isHttpExceptionCode = is_int($exceptionCode) && Status::getReasonPhrase($exceptionCode) !== 'Unknown';
+
+        return $isHttpExceptionCode ? $exceptionCode : Status::INTERNAL_SERVER_ERROR;
+    }
 }

tests/Unit/Middleware/MetricMiddlewareTest.php

@@ -143,11 +143,14 @@ public function testProcessWithMetricsDisabled(): void
         $this->assertSame($this->response, $result);
     }
 
-    public function testProcessWithException(): void
+    /**
+     * @dataProvider exceptionCodeProvider
+     */
+    public function testProcessWithException(int $exceptionCode, int $expectedStatusCode): void
     {
         $path = '/api/error';
         $method = 'POST';
-        $exception = new RuntimeException('Test exception');
+        $exception = new RuntimeException('Test exception', $exceptionCode);
 
         $this->uri->method('getPath')->willReturn($path);
         $this->request->method('getMethod')->willReturn($method);
@@ -169,7 +172,7 @@ public function testProcessWithException(): void
                     HttpAttributes::HTTP_ROUTE => $path,
                     HttpAttributes::HTTP_REQUEST_METHOD => $method,
                     ErrorAttributes::ERROR_TYPE => RuntimeException::class,
-                    HttpAttributes::HTTP_RESPONSE_STATUS_CODE => 500,
+                    HttpAttributes::HTTP_RESPONSE_STATUS_CODE => $expectedStatusCode,
                 ]
             );
 
@@ -185,6 +188,24 @@ public function testProcessWithException(): void
         $middleware->process($this->request, $handler);
     }
 
+    public static function exceptionCodeProvider(): array
+    {
+        return [
+            'Default exception code' => [
+                'exceptionCode' => 0,
+                'expectedStatusCode' => 500,
+            ],
+            'Http exception code' => [
+                'exceptionCode' => 422,
+                'expectedStatusCode' => 422,
+            ],
+            'Custom exception code' => [
+                'exceptionCode' => 1000,
+                'expectedStatusCode' => 500,
+            ],
+        ];
+    }
+
     private function configureRequestMock(string $method, string $path): void
     {
         $this->uri->method('getPath')->willReturn($path);