fix: sanitize initialDelayMs in retryOnTransientError to prevent warnings

Signed-off-by: leocavalcante <[email protected]>

Author: leocavalcante

src/paths.mjs

@@ -177,6 +177,10 @@ function delay(ms) {
  */
 export async function retryOnTransientError(fn, options = {}) {
 	const { retries = 3, initialDelayMs = 100 } = options
+	// Sanitize initialDelayMs: clamp negative to 0, handle NaN by using default
+	const sanitizedDelayMs = Number.isNaN(initialDelayMs)
+		? 100
+		: Math.max(0, initialDelayMs)
 	let lastError
 
 	for (let attempt = 0; attempt <= retries; attempt++) {
@@ -191,8 +195,8 @@ export async function retryOnTransientError(fn, options = {}) {
 				throw err
 			}
 
-			// Calculate exponential backoff delay: initialDelayMs * 2^attempt
-			const backoffDelay = initialDelayMs * 2 ** attempt
+			// Calculate exponential backoff delay: sanitizedDelayMs * 2^attempt
+			const backoffDelay = sanitizedDelayMs * 2 ** attempt
 			await delay(backoffDelay)
 		}
 	}

tests/paths.test.ts

@@ -595,7 +595,7 @@ describe("paths.mjs exports", () => {
 				expect(elapsed).toBeLessThan(50)
 			})
 
-			it("should handle negative initialDelayMs (treated as ~1ms delay by setTimeout)", async () => {
+			it("should handle negative initialDelayMs (clamped to 0ms)", async () => {
 				let callCount = 0
 				const start = Date.now()
 				await retryOnTransientError(
@@ -611,7 +611,7 @@ describe("paths.mjs exports", () => {
 				)
 				const elapsed = Date.now() - start
 				expect(callCount).toBe(2)
-				// Negative delay is clamped to ~1ms by setTimeout, should complete quickly
+				// Negative delay is clamped to 0ms, should complete quickly
 				expect(elapsed).toBeLessThan(50)
 			})
 
@@ -632,11 +632,10 @@ describe("paths.mjs exports", () => {
 				expect(callCount).toBe(0) // Loop never runs
 			})
 
-			it("should handle non-numeric initialDelayMs (NaN becomes ~1ms delay)", async () => {
+			it("should handle non-numeric initialDelayMs (NaN falls back to default 100ms)", async () => {
 				let callCount = 0
 				const start = Date.now()
-				// When initialDelayMs is NaN, delay calculation produces NaN
-				// setTimeout with NaN delay treats it as ~1ms
+				// When initialDelayMs is NaN, it is sanitized to the default 100ms
 				await retryOnTransientError(
 					() => {
 						callCount++
@@ -650,8 +649,9 @@ describe("paths.mjs exports", () => {
 				)
 				const elapsed = Date.now() - start
 				expect(callCount).toBe(2)
-				// NaN delay becomes ~1ms
-				expect(elapsed).toBeLessThan(50)
+				// NaN delay falls back to default 100ms
+				expect(elapsed).toBeGreaterThanOrEqual(90)
+				expect(elapsed).toBeLessThan(200)
 			})
 
 			it("should handle Infinity retries (up to a reasonable test limit)", async () => {