refactor: extract EXPECTED_AGENTS constant and add consistency test

Signed-off-by: leocavalcante <[email protected]>

Author: leocavalcante

src/paths.d.mts

@@ -10,6 +10,12 @@ export {
 	parseVersion,
 } from "./semver.mjs"
 
+/**
+ * List of expected agent names (without .md extension).
+ * This is the single source of truth for agent filenames.
+ */
+export declare const AGENT_NAMES: string[]
+
 /** Minimum character count for valid agent files */
 export declare const MIN_CONTENT_LENGTH: number
 

src/paths.mjs

@@ -16,6 +16,12 @@ export {
 	parseVersion,
 } from "./semver.mjs"
 
+/**
+ * List of expected agent names (without .md extension).
+ * This is the single source of truth for agent filenames.
+ */
+export const AGENT_NAMES = ["opencoder", "opencoder-planner", "opencoder-builder"]
+
 /** Minimum character count for valid agent files */
 export const MIN_CONTENT_LENGTH = 100
 

tests/agents.test.ts

@@ -2,6 +2,8 @@ import { afterEach, beforeEach, describe, expect, it } from "bun:test"
 import { existsSync, mkdirSync, readdirSync, readFileSync, rmSync, writeFileSync } from "node:fs"
 import { tmpdir } from "node:os"
 import { join } from "node:path"
+import { agents } from "../src/metadata"
+import { AGENT_NAMES } from "../src/paths.mjs"
 
 describe("postinstall.mjs", () => {
 	const testDir = join(tmpdir(), `opencoder-test-${Date.now()}`)
@@ -58,6 +60,32 @@ describe("agent files existence", () => {
 	})
 })
 
+describe("agent metadata consistency", () => {
+	const agentsDir = join(import.meta.dir, "..", "agents")
+
+	it("should have AGENT_NAMES match agents export from metadata", () => {
+		expect(AGENT_NAMES).toEqual(agents)
+	})
+
+	it("should have agents export match actual files in agents/ directory", () => {
+		const actualFiles = readdirSync(agentsDir)
+			.filter((f) => f.endsWith(".md"))
+			.map((f) => f.replace(/\.md$/, ""))
+			.sort()
+		const expectedAgents = [...agents].sort()
+		expect(actualFiles).toEqual(expectedAgents)
+	})
+
+	it("should have AGENT_NAMES match actual files in agents/ directory", () => {
+		const actualFiles = readdirSync(agentsDir)
+			.filter((f) => f.endsWith(".md"))
+			.map((f) => f.replace(/\.md$/, ""))
+			.sort()
+		const expectedAgents = [...AGENT_NAMES].sort()
+		expect(actualFiles).toEqual(expectedAgents)
+	})
+})
+
 describe("agent files YAML frontmatter", () => {
 	const agentsDir = join(import.meta.dir, "..", "agents")
 	const agentFiles = ["opencoder.md", "opencoder-planner.md", "opencoder-builder.md"]