fix: force legacy guests to complete profile

Author: kewitz

server/controllers/users.ts

@@ -470,7 +470,11 @@ export async function verifyEmail(req: express.Request, res: express.Response) {
                   { transaction },
                 );
                 if (user.collective) {
-                  await user.collective.update({ data: omit(user.collective.data, ['isSuspended']) }, { transaction });
+                  let newData = omit(user.collective.data, ['isSuspended']);
+                  if (user.collective.data?.isGuest) {
+                    newData = { ...newData, isGuest: false, wasGuest: true, requiresProfileCompletion: true };
+                  }
+                  await user.collective.update({ data: newData }, { transaction });
                 }
               });
               await sessionCache.delete(otpSessionKey);

server/lib/guest-accounts.ts

@@ -115,7 +115,7 @@ export const confirmGuestAccount = async (
       !newName || newName === 'Incognito'
         ? `user-${uuid().split('-')[0]}`
         : await models.Collective.generateSlug([newName]),
-    data: { ...userCollective.data, isGuest: false, wasGuest: true },
+    data: { ...userCollective.data, isGuest: false, wasGuest: true, requiresProfileCompletion: true },
   });
 
   return { user, collective: userCollective };