debt: Remove legacy expense flow code

Author: Benjamin Piouffle

cron/daily/50-check-virtual-cards-missing-receipts.ts

@@ -24,7 +24,7 @@ const processVirtualCard = async (expenses: Array<Expense>) => {
   const data = {
     expenses: expenses.map(e => ({
       ...e.info,
-      url: `${config.host.website}/${collective.slug}/expenses/${e.id}?edit=1`,
+      url: `${config.host.website}/${collective.slug}/expenses/${e.id}`,
     })),
     virtualCard,
     host: host.info,

server/graphql/v1/CollectiveInterface.js

@@ -52,7 +52,6 @@ import {
   PaginatedPaymentMethodsType,
   PaymentMethodBatchInfo,
   PaymentMethodType,
-  PayoutMethodType,
   TierType,
   UserType,
 } from './types';
@@ -608,10 +607,6 @@ export const CollectiveInterfaceType = new GraphQLInterfaceType({
           },
         },
       },
-      payoutMethods: {
-        type: new GraphQLList(PayoutMethodType),
-        description: 'The list of payout methods that this collective can use to get paid',
-      },
       giftCardsBatches: {
         type: new GraphQLList(PaymentMethodBatchInfo),
         description:
@@ -1649,24 +1644,6 @@ const CollectiveFields = () => {
         return paymentMethods.filter(pm => !pm.expiryDate || pm.expiryDate > now);
       },
     },
-    payoutMethods: {
-      type: new GraphQLList(PayoutMethodType),
-      description: 'The list of payout methods that this collective can use to get paid',
-      async resolve(collective, _, req) {
-        if (!req.remoteUser || !req.remoteUser.isAdminOfCollective(collective)) {
-          return null;
-        } else {
-          const payoutMethods = await req.loaders.PayoutMethod.byCollectiveId.load(collective.id);
-          return payoutMethods.filter(pm => {
-            if (pm.type === PayoutMethodTypes.STRIPE && collective.id !== PlatformConstants.OfitechCollectiveId) {
-              return false;
-            }
-
-            return true;
-          });
-        }
-      },
-    },
     giftCardsBatches: {
       type: new GraphQLList(PaymentMethodBatchInfo),
       description:

server/graphql/v1/types.js

@@ -26,7 +26,6 @@ import { filterContributors } from '../../lib/contributors';
 import { sanitizeStripeError } from '../../lib/stripe';
 import twoFactorAuthLib from '../../lib/two-factor-authentication';
 import models, { Op, sequelize } from '../../models';
-import { PayoutMethodTypes } from '../../models/PayoutMethod';
 import { canSeeExpenseAttachments, canSeeExpensePayoutMethodPrivateDetails } from '../common/expenses';
 import { hasSeenLatestChangelogEntry } from '../common/user';
 import { Unauthorized } from '../errors';
@@ -84,36 +83,6 @@ const IsoDateString = new GraphQLScalarType({
   },
 });
 
-const PayoutMethodTypeEnum = new GraphQLEnumType({
-  name: 'PayoutMethodTypeEnum',
-  values: Object.keys(PayoutMethodTypes).reduce((values, key) => {
-    return { ...values, [key]: { value: PayoutMethodTypes[key] } };
-  }, {}),
-});
-
-// @deprecated Still used in Collective.payoutMethods by `expenseFormPayeeStepCollectivePickerSearchQuery`
-export const PayoutMethodType = new GraphQLObjectType({
-  name: 'PayoutMethod',
-  description: 'A payout method for expenses',
-  fields: () => ({
-    id: {
-      type: GraphQLInt,
-    },
-    type: {
-      type: PayoutMethodTypeEnum,
-    },
-    name: {
-      type: GraphQLString,
-    },
-    isSaved: {
-      type: GraphQLBoolean,
-    },
-    data: {
-      type: GraphQLJSON,
-    },
-  }),
-});
-
 export const UserType = new GraphQLObjectType({
   name: 'UserDetails',
   description: 'This represents the details of a User',

templates/emails/collective.expense.missing.receipt.hbs

@@ -18,7 +18,7 @@ For accounting reasons, the Fiscal Host will need a description and receipt. The
 <br />
 
 <center>
-  <a href="{{config.host.website}}/{{collective.slug}}/expenses/{{expense.id}}?edit=1" class="btn blue">
+  <a href="{{config.host.website}}/{{collective.slug}}/expenses/{{expense.id}}" class="btn blue">
     <div>Submit Receipt</div>
   </a>
 </center>

templates/emails/virtualcard.purchase.hbs

@@ -11,14 +11,14 @@ Subject: Virtual Card Purchase
 <p>
 A card attached to {{collective.name}} was charged {{currency amount currency=currency precision=2}} and we need the responsible admin to input additional information.
 
-For accounting reasons, the Fiscal Host will need a description and receipt. Please <a href="{{config.host.website}}/{{collective.slug}}/expenses/{{expense.id}}?edit=1">upload a receipt</a> if you already have one. The card may be suspended if receipts are not provided.
+For accounting reasons, the Fiscal Host will need a description and receipt. Please <a href="{{config.host.website}}/{{collective.slug}}/expenses/{{expense.id}}">upload a receipt</a> if you already have one. The card may be suspended if receipts are not provided.
 </p>
 
 <br />
 <br />
 
 <center>
-  <a href="{{config.host.website}}/{{collective.slug}}/expenses/{{expense.id}}?edit=1" class="btn blue">
+  <a href="{{config.host.website}}/{{collective.slug}}/expenses/{{expense.id}}" class="btn blue">
     <div>Submit Receipt</div>
   </a>
 </center>

test/server/paymentProviders/stripe/virtual-cards.test.js

@@ -84,6 +84,6 @@ describe('server/paymentProviders/stripe/virtual-cards', () => {
     expect(emailTo).to.equal(collectiveAdmin.email);
     expect(subject).to.equal('Virtual Card Purchase');
     expect(body).to.contain('A card attached to Open Collective was charged $1.00.');
-    expect(body).to.contain(`<a href="${config.host.website}/${collective.slug}/expenses/${expense.id}?edit=1"`);
+    expect(body).to.contain(`<a href="${config.host.website}/${collective.slug}/expenses/${expense.id}"`);
   });
 });