[codegen][rocdl] Remove ROCDLKernelConfig and ROCDLSelectLoweringStrategy (iree-org#21820)

This patch removes removes:
- ROCDLKernelConfig.h
- ROCDLKernelConfig.cpp
- ROCDLSelectLoweringStrategy.cpp

The reason for removal is that they are not being used by any pipeline,
and are not being properly tested.

---------

Signed-off-by: Fabian Mora <[email protected]>
Signed-off-by: Ivan Ho <[email protected]>

Author: fabianmcg

compiler/src/iree/compiler/Codegen/LLVMGPU/BUILD.bazel

@@ -113,18 +113,15 @@ iree_compiler_cc_library(
         "ROCDLAnnotateKernelForTranslation.cpp",
         "ROCDLBufferInstructionsOptimization.cpp",
         "ROCDLConfigureBufferInstructions.cpp",
-        "ROCDLKernelConfig.cpp",
         "ROCDLLowerExecutableTarget.cpp",
         "ROCDLPrefetching.cpp",
-        "ROCDLSelectLoweringStrategy.cpp",
         "TestLLVMGPUQueryMMAPass.cpp",
         "Verifiers.cpp",
     ],
     hdrs = [
         "ConvertToLLVM.h",
         "KernelConfig.h",
         "Passes.h",
-        "ROCDLKernelConfig.h",
         "ROCDLPasses.h",
     ],
     deps = [

compiler/src/iree/compiler/Codegen/LLVMGPU/CMakeLists.txt

@@ -67,7 +67,6 @@ iree_cc_library(
     "ConvertToLLVM.h"
     "KernelConfig.h"
     "Passes.h"
-    "ROCDLKernelConfig.h"
     "ROCDLPasses.h"
   SRCS
     "AMDGPUEmulateNarrowType.cpp"
@@ -93,10 +92,8 @@ iree_cc_library(
     "ROCDLAnnotateKernelForTranslation.cpp"
     "ROCDLBufferInstructionsOptimization.cpp"
     "ROCDLConfigureBufferInstructions.cpp"
-    "ROCDLKernelConfig.cpp"
     "ROCDLLowerExecutableTarget.cpp"
     "ROCDLPrefetching.cpp"
-    "ROCDLSelectLoweringStrategy.cpp"
     "TestLLVMGPUQueryMMAPass.cpp"
     "Verifiers.cpp"
   DEPS

compiler/src/iree/compiler/Codegen/LLVMGPU/Passes.cpp

@@ -1199,27 +1199,6 @@ void buildLLVMGPULinkingPassPipeline(OpPassManager &modulePassManager,
 // ROCDL Pass Pipelines
 //===----------------------------------------------------------------------===//
 
-static void buildROCDLCodegenConfigurationPassPipelineImpl(
-    OpPassManager &modulePassManager) {
-  {
-    FunctionLikeNest funcPassManager(modulePassManager);
-    funcPassManager.addPass(createGPUGeneralizeNamedOpsPass);
-    funcPassManager.addPass(createROCDLConfigureBufferInstructionsPass);
-    addCommonTargetExecutablePreprocessingPasses(funcPassManager);
-  }
-  modulePassManager.addPass(createMaterializeTuningSpecsPass());
-  modulePassManager.addPass(createMaterializeUserConfigsPass());
-
-  modulePassManager.addPass(createROCDLSelectLoweringStrategyPass());
-}
-
-void buildROCDLCodegenConfigurationPassPipeline(
-    OpPassManager &variantPassManager) {
-  variantPassManager.addPass(createSpecializeExportsPass());
-  OpPassManager &modulePassManager = variantPassManager.nest<ModuleOp>();
-  buildROCDLCodegenConfigurationPassPipelineImpl(modulePassManager);
-}
-
 void buildROCDLCodegenPassPipeline(OpPassManager &variantPassManager) {
   {
     OpPassManager &modulePassManager = variantPassManager.nest<ModuleOp>();
@@ -1299,13 +1278,6 @@ void registerCodegenROCDLPasses() {
   // Generated.
   rocdl::registerPasses();
 
-  static PassPipelineRegistration<> ROCDLConfigPipeline(
-      "iree-codegen-rocdl-configuration-pipeline",
-      "Runs pass pipeline to select a suitable lowering strategy for ROCDL",
-      [](OpPassManager &modulePassManager) {
-        buildROCDLCodegenConfigurationPassPipelineImpl(modulePassManager);
-      });
-
   static PassPipelineRegistration<> LinalgROCDLPipeline(
       "iree-codegen-linalg-to-rocdl-pipeline2",
       "Runs pass pipeline to progressively lower Linalg to ROCDL",

compiler/src/iree/compiler/Codegen/LLVMGPU/ROCDLKernelConfig.cpp

@@ -56,10 +56,4 @@ def ROCDLLowerExecutableTargetPass : InterfacePass<
                 "pass pipeline";
 }
 
-def ROCDLSelectLoweringStrategyPass :
-    Pass<"iree-rocdl-select-lowering-strategy", "ModuleOp"> {
-  let summary = "Select a suitable lowering strategy for an IREE "
-                "hal.executable.variant op";
-}
-
 #endif // IREE_CODEGEN_LLVMGPU_ROCDLPASSES

compiler/src/iree/compiler/Codegen/LLVMGPU/ROCDLKernelConfig.h

@@ -38,7 +38,6 @@ iree_lit_test_suite(
             "config_winograd.mlir",
             "extract_address_computation_gpu.mlir",
             "gpu_pipeline_data_tiling.mlir",
-            "gpu_pipeline_generalize_named_ops.mlir",
             "gpu_pipeline_relayout_ops.mlir",
             "horizontal_fusion_pipeline.mlir",
             "link_executables.mlir",

compiler/src/iree/compiler/Codegen/LLVMGPU/ROCDLPasses.td

@@ -35,7 +35,6 @@ iree_lit_test_suite(
     "elementwise_pipeline.mlir"
     "extract_address_computation_gpu.mlir"
     "gpu_pipeline_data_tiling.mlir"
-    "gpu_pipeline_generalize_named_ops.mlir"
     "gpu_pipeline_relayout_ops.mlir"
     "horizontal_fusion_pipeline.mlir"
     "legalize.mlir"

compiler/src/iree/compiler/Codegen/LLVMGPU/ROCDLSelectLoweringStrategy.cpp

@@ -29,7 +29,6 @@ iree_lit_test_suite(
             "config_vector_distribute_gfx950.mlir",
             "config_user_vector_distribute.mlir",
             "configure_buffer_instructions.mlir",
-            "lowering_scalar_dispatch.mlir",
             "pipeline_elementwise_f8fnuz.mlir",
             "pipeline_elementwise_f8ocp.mlir",
             "pipeline_igemm_tile_and_fuse.mlir",