Skip to content

Commit d337ad2

Browse files
hanhanWhhkit
authored andcommitted
[LinalgExt][NFC] Delete duplicated SingleBlockImplicitTerminator trait. (iree-org#21818)
They are already included by IREELinalgExt_Op: https://github.com/iree-org/iree/blob/f0e04ae7dfafd203fb3f88b29dc228b51a06a8a4/compiler/src/iree/compiler/Dialect/LinalgExt/IR/LinalgExtOps.td#L28-L38 Signed-off-by: hanhanW <[email protected]> Signed-off-by: Ivan Ho <[email protected]>
1 parent a9eef59 commit d337ad2

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

compiler/src/iree/compiler/Dialect/LinalgExt/IR/LinalgExtOps.td

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -328,8 +328,7 @@ def IREELinalgExt_MapScatterOp : IREELinalgExt_PureOp<"map_scatter",
328328
"getTiledImplementation",
329329
"getIterationDomainTileFromOperandTiles",
330330
"getTiledImplementationFromOperandTiles",
331-
"generateScalarImplementation"]>,
332-
SingleBlockImplicitTerminator<"::mlir::iree_compiler::IREE::LinalgExt::YieldOp">]> {
331+
"generateScalarImplementation"]>]> {
333332
let summary = [{Scatter with a mapping from source indices to result indices.}];
334333
let description = [{
335334
Takes two operands, `input` and `output`, and stores every element of
@@ -678,7 +677,6 @@ def IREELinalgExt_TopkOp : IREELinalgExt_Op<"topk",[
678677
}
679678

680679
def IREELinalgExt_ArgCompareOp : IREELinalgExt_Op<"arg_compare", [
681-
SingleBlockImplicitTerminator<"::mlir::iree_compiler::IREE::LinalgExt::YieldOp">,
682680
DeclareOpInterfaceMethods<ReifyRankedShapedTypeOpInterface>,
683681
DeclareOpInterfaceMethods<LinalgExtInterface>,
684682
DeclareOpInterfaceMethods<TilingInterface,
@@ -801,7 +799,6 @@ def IREELinalgExt_ArgCompareOp : IREELinalgExt_Op<"arg_compare", [
801799

802800
def IREELinalgExt_AttentionOp : IREELinalgExt_PureOp<"attention",
803801
[DeclareOpInterfaceMethods<MemoryEffectsOpInterface>,
804-
SingleBlockImplicitTerminator<"::mlir::iree_compiler::IREE::LinalgExt::YieldOp">,
805802
DestinationStyleOpInterface, LinalgExtInterface,
806803
DeclareOpInterfaceMethods<LinalgFusionInterface,
807804
["getIndexingMapsForResults", "getIndexingMapsForOperands",
@@ -914,7 +911,6 @@ def IREELinalgExt_AttentionOp : IREELinalgExt_PureOp<"attention",
914911

915912
def IREELinalgExt_OnlineAttentionOp : IREELinalgExt_PureOp<"online_attention",
916913
[DeclareOpInterfaceMethods<MemoryEffectsOpInterface>,
917-
SingleBlockImplicitTerminator<"::mlir::iree_compiler::IREE::LinalgExt::YieldOp">,
918914
DestinationStyleOpInterface,
919915
IndexingMapOpInterface,
920916
LinalgExtInterface,

0 commit comments

Comments
 (0)