Skip to content

Commit 3e992d8

Browse files
dc03dc03
committed
[InferAlignment] Enable InferAlignment pass by default
This gives an improvement of 0.6%: https://llvm-compile-time-tracker.com/compare.php?from=7d35fe6d08e2b9b786e1c8454cd2391463832167&to=0456c8e8a42be06b62ad4c3e3cf34b21f2633d1e&stat=instructions:u Differential Revision: https://reviews.llvm.org/D158600
1 parent 0104f37 commit 3e992d8

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

51 files changed

+260
-322
lines changed

‎llvm/lib/Passes/PassBuilderPipelines.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ cl::opt<bool> EnableMemProfContextDisambiguation(
276276
cl::ZeroOrMore, cl::desc("Enable MemProf context disambiguation"));
277277

278278
cl::opt<bool> EnableInferAlignmentPass(
279-
"enable-infer-alignment-pass", cl::init(false), cl::Hidden, cl::ZeroOrMore,
279+
"enable-infer-alignment-pass", cl::init(true), cl::Hidden, cl::ZeroOrMore,
280280
cl::desc("Enable the InferAlignment pass, disabling alignment inference in "
281281
"InstCombine"));
282282

‎llvm/test/Analysis/BasicAA/featuretest.ll‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ define i32 @gep_distance_test3(ptr %A) {
131131
;
132132
; USE_ASSUME-LABEL: @gep_distance_test3(
133133
; USE_ASSUME-NEXT: [[C:%.*]] = getelementptr i8, ptr [[A:%.*]], i64 4
134-
; USE_ASSUME-NEXT: store i8 42, ptr [[C]], align 4
134+
; USE_ASSUME-NEXT: store i8 42, ptr [[C]], align 1
135135
; USE_ASSUME-NEXT: call void @llvm.assume(i1 true) [ "dereferenceable"(ptr [[A]], i64 4), "nonnull"(ptr [[A]]), "align"(ptr [[A]], i64 4) ]
136136
; USE_ASSUME-NEXT: ret i32 0
137137
;

‎llvm/test/Analysis/ValueTracking/assume.ll‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ define dso_local i32 @test4a(ptr readonly %0, i1 %cond) {
100100
; CHECK: A:
101101
; CHECK-NEXT: br i1 false, label [[TMP4:%.*]], label [[TMP2:%.*]]
102102
; CHECK: 2:
103-
; CHECK-NEXT: [[TMP3:%.*]] = load i32, ptr [[TMP0]], align 8
103+
; CHECK-NEXT: [[TMP3:%.*]] = load i32, ptr [[TMP0]], align 4
104104
; CHECK-NEXT: br label [[TMP4]]
105105
; CHECK: 4:
106106
; CHECK-NEXT: [[TMP5:%.*]] = phi i32 [ [[TMP3]], [[TMP2]] ], [ poison, [[A]] ]

‎llvm/test/CodeGen/AMDGPU/implicit-arg-v5-opt.ll‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
2-
; RUN: opt -mtriple=amdgcn-amd-amdhsa -S -passes=amdgpu-lower-kernel-attributes,instcombine %s | FileCheck -enable-var-scope -check-prefix=GCN %s
2+
; RUN: opt -mtriple=amdgcn-amd-amdhsa -S -passes=amdgpu-lower-kernel-attributes,instcombine,infer-alignment %s | FileCheck -enable-var-scope -check-prefix=GCN %s
33

44
; Function Attrs: mustprogress nofree norecurse nosync nounwind readnone willreturn
55
define amdgpu_kernel void @get_local_size_x(ptr addrspace(1) %out) #0 {

‎llvm/test/CodeGen/AMDGPU/reqd-work-group-size.ll‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
; RUN: opt -mtriple=amdgcn-amd-amdhsa -S -passes=amdgpu-lower-kernel-attributes,instcombine %s | FileCheck -enable-var-scope %s
2-
; RUN: opt -mtriple=amdgcn-amd-amdhsa -S -passes=amdgpu-lower-kernel-attributes,instcombine %s | FileCheck -enable-var-scope %s
1+
; RUN: opt -mtriple=amdgcn-amd-amdhsa -S -passes=amdgpu-lower-kernel-attributes,instcombine,infer-alignment %s | FileCheck -enable-var-scope %s
2+
; RUN: opt -mtriple=amdgcn-amd-amdhsa -S -passes=amdgpu-lower-kernel-attributes,instcombine,infer-alignment %s | FileCheck -enable-var-scope %s
33

44
target datalayout = "n32"
55

‎llvm/test/Other/new-pm-defaults.ll‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -246,6 +246,7 @@
246246
; CHECK-O-NEXT: Running analysis: LoopAccessAnalysis on foo
247247
; CHECK-O-NEXT: Running pass: InjectTLIMappings
248248
; CHECK-O-NEXT: Running pass: LoopVectorizePass
249+
; CHECK-O-NEXT: Running pass: InferAlignmentPass
249250
; CHECK-O-NEXT: Running pass: LoopLoadEliminationPass
250251
; CHECK-O-NEXT: Running pass: InstCombinePass
251252
; CHECK-O-NEXT: Running pass: SimplifyCFGPass
@@ -257,6 +258,7 @@
257258
; CHECK-O-NEXT: Running pass: LoopUnrollPass
258259
; CHECK-O-NEXT: Running pass: WarnMissedTransformationsPass
259260
; CHECK-O-NEXT: Running pass: SROAPass
261+
; CHECK-O-NEXT: Running pass: InferAlignmentPass
260262
; CHECK-O-NEXT: Running pass: InstCombinePass
261263
; CHECK-O-NEXT: Running pass: LoopSimplifyPass
262264
; CHECK-O-NEXT: Running pass: LCSSAPass

‎llvm/test/Other/new-pm-lto-defaults.ll‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@
116116
; CHECK-O23SZ-NEXT: Running analysis: LoopAccessAnalysis on foo
117117
; CHECK-O23SZ-NEXT: Running pass: LoopVectorizePass on foo
118118
; CHECK-O23SZ-NEXT: Running analysis: DemandedBitsAnalysis on foo
119+
; CHECK-O23SZ-NEXT: Running pass: InferAlignmentPass on foo
119120
; CHECK-O23SZ-NEXT: Running pass: LoopUnrollPass on foo
120121
; CHECK-O23SZ-NEXT: WarnMissedTransformationsPass on foo
121122
; CHECK-O23SZ-NEXT: Running pass: SROAPass on foo
@@ -128,6 +129,7 @@
128129
; CHECK-O3-NEXT: Running pass: SLPVectorizerPass on foo
129130
; CHECK-OS-NEXT: Running pass: SLPVectorizerPass on foo
130131
; CHECK-O23SZ-NEXT: Running pass: VectorCombinePass on foo
132+
; CHECK-O23SZ-NEXT: Running pass: InferAlignmentPass on foo
131133
; CHECK-O23SZ-NEXT: Running pass: InstCombinePass on foo
132134
; CHECK-O23SZ-NEXT: Running pass: LoopSimplifyPass
133135
; CHECK-O23SZ-NEXT: Running pass: LCSSAPass

‎llvm/test/Other/new-pm-thinlto-postlink-defaults.ll‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,7 @@
173173
; CHECK-POSTLINK-O-NEXT: Running analysis: LoopAccessAnalysis on foo
174174
; CHECK-POSTLINK-O-NEXT: Running pass: InjectTLIMappings
175175
; CHECK-POSTLINK-O-NEXT: Running pass: LoopVectorizePass
176+
; CHECK-POSTLINK-O-NEXT: Running pass: InferAlignmentPass
176177
; CHECK-POSTLINK-O-NEXT: Running pass: LoopLoadEliminationPass
177178
; CHECK-POSTLINK-O-NEXT: Running pass: InstCombinePass
178179
; CHECK-POSTLINK-O-NEXT: Running pass: SimplifyCFGPass
@@ -184,6 +185,7 @@
184185
; CHECK-POSTLINK-O-NEXT: Running pass: LoopUnrollPass
185186
; CHECK-POSTLINK-O-NEXT: Running pass: WarnMissedTransformationsPass
186187
; CHECK-POSTLINK-O-NEXT: Running pass: SROAPass
188+
; CHECK-POSTLINK-O-NEXT: Running pass: InferAlignmentPass
187189
; CHECK-POSTLINK-O-NEXT: Running pass: InstCombinePass
188190
; CHECK-POSTLINK-O-NEXT: Running pass: LoopSimplifyPass
189191
; CHECK-POSTLINK-O-NEXT: Running pass: LCSSAPass

‎llvm/test/Other/new-pm-thinlto-postlink-pgo-defaults.ll‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,7 @@
160160
; CHECK-O-NEXT: Running analysis: LoopAccessAnalysis on foo
161161
; CHECK-O-NEXT: Running pass: InjectTLIMappings
162162
; CHECK-O-NEXT: Running pass: LoopVectorizePass
163+
; CHECK-O-NEXT: Running pass: InferAlignmentPass
163164
; CHECK-O-NEXT: Running pass: LoopLoadEliminationPass
164165
; CHECK-O-NEXT: Running pass: InstCombinePass
165166
; CHECK-O-NEXT: Running pass: SimplifyCFGPass
@@ -171,6 +172,7 @@
171172
; CHECK-O-NEXT: Running pass: LoopUnrollPass
172173
; CHECK-O-NEXT: Running pass: WarnMissedTransformationsPass
173174
; CHECK-O-NEXT: Running pass: SROAPass
175+
; CHECK-O-NEXT: Running pass: InferAlignmentPass
174176
; CHECK-O-NEXT: Running pass: InstCombinePass
175177
; CHECK-O-NEXT: Running pass: LoopSimplifyPass
176178
; CHECK-O-NEXT: Running pass: LCSSAPass

‎llvm/test/Other/new-pm-thinlto-postlink-samplepgo-defaults.ll‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,7 @@
167167
; CHECK-O-NEXT: Running analysis: LoopAccessAnalysis
168168
; CHECK-O-NEXT: Running pass: InjectTLIMappings
169169
; CHECK-O-NEXT: Running pass: LoopVectorizePass
170+
; CHECK-O-NEXT: Running pass: InferAlignmentPass
170171
; CHECK-O-NEXT: Running pass: LoopLoadEliminationPass
171172
; CHECK-O-NEXT: Running pass: InstCombinePass
172173
; CHECK-O-NEXT: Running pass: SimplifyCFGPass
@@ -178,6 +179,7 @@
178179
; CHECK-O-NEXT: Running pass: LoopUnrollPass
179180
; CHECK-O-NEXT: Running pass: WarnMissedTransformationsPass
180181
; CHECK-O-NEXT: Running pass: SROAPass
182+
; CHECK-O-NEXT: Running pass: InferAlignmentPass
181183
; CHECK-O-NEXT: Running pass: InstCombinePass
182184
; CHECK-O-NEXT: Running pass: LoopSimplifyPass
183185
; CHECK-O-NEXT: Running pass: LCSSAPass

0 commit comments

Comments
 (0)