Skip to content

Commit c516d11

Browse files
Merge pull request #151 from opencomponents/fix-log
fix log by not passing data
2 parents b2d4a18 + 1227972 commit c516d11

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

src/oc-client.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -382,9 +382,7 @@ export function createOc(oc) {
382382

383383
return {
384384
fire(key, data) {
385-
logInfo(
386-
`OC event fired: "${key}"${data ? ` with data: ${JSON.stringify(data)}` : ""}`,
387-
);
385+
logInfo(`OC event fired: "${key}"`);
388386
if (listeners[key]) {
389387
for (let cb of listeners[key]) {
390388
cb({ type: key }, data);

tests/events.spec.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -248,13 +248,9 @@ test.describe("oc-client : events", () => {
248248

249249
expect(result.logCallCount).toBe(3);
250250

251-
expect(result.logCalls[0][0]).toBe(
252-
'OC event fired: "trace:test1" with data: {"message":"hello"}',
253-
);
251+
expect(result.logCalls[0][0]).toBe('OC event fired: "trace:test1"');
254252

255-
expect(result.logCalls[1][0]).toBe(
256-
'OC event fired: "trace:test2" with data: {"count":42}',
257-
);
253+
expect(result.logCalls[1][0]).toBe('OC event fired: "trace:test2"');
258254

259255
expect(result.logCalls[2][0]).toBe('OC event fired: "trace:test3"');
260256
});

0 commit comments

Comments
 (0)