fix lint

Author: ricardo-devis-agullo

src/cli/domain/get-mocked-plugins.ts

@@ -73,13 +73,13 @@ const registerDynamicMocks = (
         pluginMock = require(path.resolve(ocJsonLocation, source));
       } catch (er) {
         logger.err(String(er));
-        return;
+        return undefined;
       }
 
       if (!isMockValid(pluginMock)) {
         logger.err(`├── ${pluginName} () => Error (skipping)`);
         logger.err(strings.errors.cli.MOCK_PLUGIN_IS_NOT_VALID);
-        return;
+        return undefined;
       }
 
       const register = (pluginMock as MockedPlugin).register || defaultRegister;

src/cli/index.ts

@@ -116,7 +116,7 @@ function processCommand(
       return yargs;
     },
     (options) => {
-      // @ts-ignore not callable
+      // @ts-expect-error not callable
       facade(options).catch(() => {
         process.exit(1);
       });

src/registry/middleware/request-handler.ts

@@ -7,7 +7,7 @@ export default function requestHandler(): RequestHandler {
   return responseTime((req: Request, res: Response, time) => {
     const data: RequestData = {
       body: req.body,
-      duration: Number.parseInt(String(time * 1000)),
+      duration: Number.parseInt(String(time * 1000), 10),
       headers: req.headers,
       method: req.method,
       path: req.path,

src/registry/routes/components.ts

@@ -98,16 +98,15 @@ export default function components(
           (result) => callback(null, result)
         );
       },
-      // @ts-ignore
       (_err: any, results: GetComponentResult[]) => {
         try {
           setHeaders(results, res);
           setCookies(results, res);
           res.status(200).json(results);
         } catch (e) {
-          // @ts-ignore I think this will never reach (how can setHeaders throw?)
+          // @ts-expect-error I think this will never reach (how can setHeaders throw?)
           if (results.code && results.error) {
-            // @ts-ignore
+            // @ts-expect-error
             res.status(500).json({ code: results.code, error: results.error });
           } else {
             res.status(500).json({

src/registry/routes/helpers/get-component.ts

@@ -256,7 +256,6 @@ export default function getComponent(conf: Config, repository: Repository) {
           component.oc.parameters
         );
         const validationResult = validator.validateComponentParameters(
-          // @ts-ignore
           params,
           component.oc.parameters
         );
@@ -336,8 +335,7 @@ export default function getComponent(conf: Config, repository: Repository) {
             {
               name: component.name,
               version: requestedComponent.version,
-              // @ts-ignore
-              parameters: params
+              parameters: params as Record<string, string>
             },
             conf.baseUrl
           );

src/registry/routes/index.ts

@@ -91,7 +91,7 @@ export default function (repository: Repository) {
 
       res.send(
         indexView(
-          // @ts-ignore existing code relies on runtime merging
+          // @ts-expect-error existing code relies on runtime merging
           Object.assign(baseResponse, {
             availableDependencies: getAvailableDependencies(
               res.conf.dependencies

src/registry/views/partials/layout.tsx

@@ -68,8 +68,7 @@ const Layout = ({ title, href, children, scripts, theme }: LayoutProps) => {
               src="//ghbtns.com/github-btn.html?user=opencomponents&repo=oc&type=watch&count=true"
               width="110"
               height="20"
-              // @ts-ignore
-              frameBorder="0"
+              frameborder="0"
             />
           </div>
           <script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/1.11.2/jquery.min.js" />