Merge pull request #1244 from opencomponents/clean-some-ts-ignore

clean up some ts-ignore comments

Author: ricardo-devis-agullo

src/cli/domain/handle-dependencies/index.ts

@@ -133,10 +133,9 @@ export default function handleDependencies(
     };
     const options = { dependencies, logger };
     if (useComponentDependencies) {
-      // @ts-ignore
-      options.componentPath = components[0];
-      return linkMissingDependencies(options as any, err =>
-        callback(err, result)
+      return linkMissingDependencies(
+        { ...options, componentPath: components[0] },
+        err => callback(err, result)
       );
     }
     installMissingDependencies(options, err => callback(err, result));

src/cli/domain/init-template/install-template.ts

@@ -30,15 +30,13 @@ export default function installTemplate(
   npm.installDependency(npmOptions, (err, result) => {
     const errorMessage = 'template type not valid';
     if (err) {
-      // @ts-ignore
-      return callback(errorMessage);
+      return callback(errorMessage, undefined as any);
     }
 
     const installedCompiler = tryRequire(result.dest);
 
     if (!isTemplateValid(installedCompiler, { compiler: true })) {
-      // @ts-ignore
-      return callback(errorMessage);
+      return callback(errorMessage, undefined as any);
     }
     const version = installedCompiler.getInfo().version;
     logger.log(

src/registry/routes/publish.ts

@@ -18,38 +18,35 @@ export default function publish(repository: Repository) {
       return;
     }
 
-    let validationResult = validator.validateOcCliVersion(
+    const ocCliValidationResult = validator.validateOcCliVersion(
       req.headers['user-agent']
     );
-    if (!validationResult.isValid) {
+    if (!ocCliValidationResult.isValid) {
       res.errorDetails = strings.errors.registry.OC_CLI_VERSION_IS_NOT_VALID(
-        validationResult.error.registryVersion,
-        validationResult.error.cliVersion
+        ocCliValidationResult.error.registryVersion,
+        ocCliValidationResult.error.cliVersion
       );
       res.status(409).json({
         code: 'cli_version_not_valid',
         error: res.errorDetails,
-        details: validationResult.error
+        details: ocCliValidationResult.error
       });
       return;
     }
 
-    // @ts-ignore
-    validationResult = validator.validateNodeVersion(
+    const nodeValidationResult = validator.validateNodeVersion(
       req.headers['user-agent'],
       process.version
     );
-    if (!validationResult.isValid) {
+    if (!nodeValidationResult.isValid) {
       res.errorDetails = strings.errors.registry.NODE_CLI_VERSION_IS_NOT_VALID(
-        // @ts-ignore
-        validationResult.error.registryNodeVersion,
-        // @ts-ignore
-        validationResult.error.cliNodeVersion
+        nodeValidationResult.error.registryNodeVersion,
+        nodeValidationResult.error.cliNodeVersion
       );
       res.status(409).json({
         code: 'node_version_not_valid',
         error: res.errorDetails,
-        details: validationResult.error
+        details: nodeValidationResult.error
       });
       return;
     }

test/unit/cli-domain-handle-dependencies-get-compiler.js

@@ -76,7 +76,6 @@ describe('cli : domain : handle-dependencies : get-compiler', () => {
         expect(installCompilerStub.args[0][0]).to.deep.equal({
           compilerPath:
             '/path/to/component/node_modules/oc-template-handlebars-compiler',
-          componentName: 'my-component',
           componentPath: '/path/to/component',
           dependency: '[email protected]',
           logger: {}
@@ -99,7 +98,6 @@ describe('cli : domain : handle-dependencies : get-compiler', () => {
         expect(installCompilerStub.args[0][0]).to.deep.equal({
           compilerPath:
             '/path/to/component/node_modules/oc-template-handlebars-compiler',
-          componentName: 'my-component',
           componentPath: '/path/to/component',
           dependency: 'oc-template-handlebars-compiler',
           logger: {}