Merge pull request #1282 from qbikez/logging

Minor logging improvements

Author: ricardo-devis-agullo

src/cli/domain/handle-dependencies/install-compiler.ts

@@ -16,7 +16,7 @@ export default function installCompiler(
 ): void {
   const { compilerPath, componentPath, dependency, logger } = options;
 
-  logger.warn(strings.messages.cli.INSTALLING_DEPS(dependency), true);
+  logger.warn(strings.messages.cli.INSTALLING_DEPS(dependency, componentPath));
 
   const npmOptions = {
     dependency,

src/cli/domain/handle-dependencies/install-missing-dependencies.ts

@@ -17,19 +17,22 @@ export default function installMissingDependencies(
     return callback(null);
   }
 
-  logger.warn(strings.messages.cli.INSTALLING_DEPS(missing.join(', ')), true);
+  const installPath = path.resolve('.');
+  
+  logger.warn(strings.messages.cli.INSTALLING_DEPS(missing.join(', '), installPath));
 
   const npmOptions = {
     dependencies: missing,
-    installPath: path.resolve('.'),
+    installPath,
     save: false,
-    silent: true,
+    silent: false,
     usePrefix: true
   };
 
   npm.installDependencies(npmOptions, err => {
     if (err || getMissingDependencies(dependencies).length) {
       logger.err('FAIL');
+      if (err) logger.err(`${err}`);
       return callback(strings.errors.cli.DEPENDENCIES_INSTALL_FAIL);
     }
 

src/cli/facade/dev.ts

@@ -77,11 +77,12 @@ const dev =
 
       if (!packaging) {
         packaging = true;
-        logger.warn(cliMessages.PACKAGING_COMPONENTS, true);
+        logger.warn(cliMessages.PACKAGING_COMPONENTS, false);
 
         async.eachSeries(
           componentsDirs,
           (dir, cb) => {
+            logger.warn(cliMessages.PACKAGING(dir), false);
             const packageOptions = {
               componentPath: dir,
               minify: false,

src/resources/index.ts

@@ -250,8 +250,8 @@ export default {
       HELP_HINT: 'Hint: Run -h with any command to show the help',
       HOT_RELOADING_DISABLED:
         'OC dev is running with hot reloading disabled so changes will be ignored',
-      INSTALLING_DEPS: (dependencies: string): string =>
-        `Trying to install missing modules: ${dependencies}\nIf you aren't connected to the internet, or npm isn't configured then this step will fail...`,
+      INSTALLING_DEPS: (dependencies: string, installPath: string): string =>
+        `Trying to install missing modules: ${dependencies} into ${installPath}/node_modules.\nIf you aren't connected to the internet, or npm isn't configured then this step will fail...`,
       LINKING_DEPENDENCIES: (dependencies: string): string =>
         `Trying to link missing modules: ${dependencies}\nThe missing dependencies will be linked to component dependencies`,
       MOCKED_PLUGIN: (name: string, value: string): string =>

test/unit/cli-domain-handle-dependencies-install-missing-dependencies.js

@@ -82,7 +82,7 @@ describe('cli : domain : handle-dependencies : install-missing-dependencies', ()
         dependencies: ['[email protected]', 'underscore@latest'],
         installPath: '/path/to/oc-running',
         save: false,
-        silent: true,
+        silent: false,
         usePrefix: true
       });
     });