Merge pull request #1313 from opencomponents/remove-some-anys

remove some any types

Author: ricardo-devis-agullo

package.json

@@ -108,8 +108,8 @@
     "oc-client-browser": "1.5.9",
     "oc-empty-response-handler": "1.0.2",
     "oc-get-unix-utc-timestamp": "1.0.6",
-    "oc-s3-storage-adapter": "2.0.0",
-    "oc-storage-adapters-utils": "2.0.0",
+    "oc-s3-storage-adapter": "2.1.1",
+    "oc-storage-adapters-utils": "2.0.2",
     "oc-template-es6": "1.0.7",
     "oc-template-es6-compiler": "2.1.0",
     "oc-template-handlebars": "6.0.25",

src/cli/domain/registry.ts

@@ -123,7 +123,7 @@ export default function registry(opts: RegistryOptions = {}) {
         ) {
           errMsg = parsedError.error;
         } else {
-          errMsg = parsedError as any;
+          errMsg = parsedError;
         }
 
         throw errMsg;

src/cli/facade/dev.ts

@@ -202,13 +202,11 @@ const dev = ({ local, logger }: { logger: Logger; local: Local }) =>
 
         return registry;
       } catch (err: any) {
-        if (err.code === 'EADDRINUSE') {
-          // eslint-disable-next-line no-ex-assign
-          err = cliErrors.PORT_IS_BUSY(port) as any;
-        }
+        const error =
+          err.code === 'EADDRINUSE' ? cliErrors.PORT_IS_BUSY(port) : err;
 
-        logger.err(String(err));
-        throw err;
+        logger.err(String(error));
+        throw error;
       }
     }
   );

src/cli/index.ts

@@ -137,6 +137,6 @@ const argv = cli
   .version()
   .wrap(cli.terminalWidth()).argv;
 
-if ((argv as any)._.length === 0) {
+if ((argv as Awaited<typeof argv>)._.length === 0) {
   cli.showHelp();
 }

src/registry/app-start.ts

@@ -61,7 +61,7 @@ export default async function appStart(
         logger.log(colors.green('Component published.'));
       } catch (err) {
         logger.log(
-          colors.red(`Component not published: ${(err as any).message}`)
+          colors.red(`Component not published: ${(err as Error).message}`)
         );
         throw err;
       }

src/registry/domain/events-handler.ts

@@ -5,13 +5,13 @@ type Subscription<T = any> = (data: T) => void;
 let subscriptions: Record<string, Array<Subscription>> = {};
 
 export interface RequestData {
-  body: any;
+  body: unknown;
   duration: number;
   headers: IncomingHttpHeaders;
   method: string;
   path: string;
   relativeUrl: string;
-  query: Record<string, any>;
+  query: Record<string, unknown>;
   url: string;
   statusCode: number;
   errorDetails?: string;

src/registry/domain/extract-package.ts

@@ -1,9 +1,9 @@
 import path from 'path';
 import targz from 'targz';
 import { promisify } from 'util';
-import { PackageJson } from 'type-fest';
 
 import getPackageJsonFromTempDir from './get-package-json-from-temp-dir';
+import { Component } from '../../types';
 
 export default async function extractPackage(
   files:
@@ -14,9 +14,9 @@ export default async function extractPackage(
   tarExtractMode: number
 ): Promise<{
   outputFolder: string;
-  packageJson: PackageJson;
+  packageJson: Component;
 }> {
-  const packageFile: Express.Multer.File = (files as any)[0];
+  const packageFile = (files as Express.Multer.File[])[0];
   const packagePath = path.resolve(packageFile.path);
   const packageUntarOutput = path.resolve(
     packageFile.path,
@@ -40,6 +40,6 @@ export default async function extractPackage(
 
   return {
     outputFolder: packageOutput,
-    packageJson: packageJson
+    packageJson
   };
 }

src/registry/domain/get-package-json-from-temp-dir.ts

@@ -1,9 +1,9 @@
 import fs from 'fs-extra';
 import path from 'path';
-import { PackageJson } from 'type-fest';
+import { Component } from '../../types';
 
 export default function getPackageJsonFromTempDir(
   tempDirPath: string
-): Promise<PackageJson> {
+): Promise<Component> {
   return fs.readJson(path.join(tempDirPath, 'package.json'));
 }

src/registry/domain/repository.ts

@@ -274,18 +274,18 @@ export default function repository(conf: Config) {
 
     getTemplatesInfo: (): TemplateInfo[] => templatesInfo,
     getTemplate: (type: string) => templatesHash[type],
-    async init(): Promise<ComponentsDetails> {
+    async init(): Promise<ComponentsDetails | undefined> {
       if (conf.local) {
         // when in local this won't get called
-        return 'ok' as any;
+        return;
       }
 
       const componentsList = await componentsCache.load();
 
       return componentsDetails.refresh(componentsList);
     },
     async publishComponent(
-      pkgDetails: any,
+      pkgDetails: { outputFolder: string; packageJson: Component },
       componentName: string,
       componentVersion: string
     ): Promise<ComponentsDetails> {

src/registry/domain/validators/package-json-validator.ts

@@ -7,7 +7,7 @@ interface ValidationResult {
 
 interface PkgDetails {
   componentName: string;
-  packageJson: { name: string };
+  packageJson: { name?: string };
   customValidator: (data: unknown) => ValidationResult | boolean;
 }