fix repo types

Author: ricardo-devis-agullo

src/registry/domain/repository.ts

@@ -11,7 +11,12 @@ import * as validator from './validators';
 import getPromiseBasedAdapter from './storage-adapter';
 import * as versionHandler from './version-handler';
 import errorToString from '../../utils/error-to-string';
-import { Component, Config } from '../../types';
+import {
+  Component,
+  ComponentsDetails,
+  Config,
+  TemplateInfo
+} from '../../types';
 import { StorageAdapter } from 'oc-storage-adapters-utils';
 
 const packageInfo = fs.readJsonSync(
@@ -110,7 +115,10 @@ export default function repository(conf: Config) {
   };
 
   const repository = {
-    getCompiledView(componentName: string, componentVersion: string) {
+    getCompiledView(
+      componentName: string,
+      componentVersion: string
+    ): Promise<string> {
       if (conf.local) {
         return Promise.resolve(local.getCompiledView(componentName));
       }
@@ -119,7 +127,10 @@ export default function repository(conf: Config) {
         getFilePath(componentName, componentVersion, 'template.js')
       );
     },
-    async getComponent(componentName: string, componentVersion?: string) {
+    async getComponent(
+      componentName: string,
+      componentVersion?: string
+    ): Promise<Component> {
       const allVersions = await repository.getComponentVersions(componentName);
 
       if (allVersions.length === 0) {
@@ -150,7 +161,10 @@ export default function repository(conf: Config) {
 
       return Object.assign(component, { allVersions });
     },
-    getComponentInfo(componentName: string, componentVersion: string) {
+    getComponentInfo(
+      componentName: string,
+      componentVersion: string
+    ): Promise<Component> {
       if (conf.local) {
         let componentInfo: Component;
 
@@ -180,29 +194,29 @@ export default function repository(conf: Config) {
         false
       );
     },
-    getComponentPath(componentName: string, componentVersion: string) {
+    getComponentPath(componentName: string, componentVersion: string): string {
       const prefix = conf.local
         ? conf.baseUrl
         : `${options!['path']}${options!.componentsDir}/`;
       return `${prefix}${componentName}/${componentVersion}/`;
     },
-    async getComponents() {
+    async getComponents(): Promise<string[]> {
       if (conf.local) {
         return local.getComponents();
       }
 
       const { components } = await componentsCache.get();
       return Object.keys(components);
     },
-    getComponentsDetails() {
+    getComponentsDetails(): Promise<ComponentsDetails> {
       if (conf.local) {
         // when in local this won't get called
         return Promise.resolve(null) as any;
       }
 
       return componentsDetails.get();
     },
-    async getComponentVersions(componentName: string) {
+    async getComponentVersions(componentName: string): Promise<string[]> {
       if (conf.local) {
         return local.getComponentVersions(componentName);
       }
@@ -211,7 +225,13 @@ export default function repository(conf: Config) {
 
       return res.components[componentName] ? res.components[componentName] : [];
     },
-    async getDataProvider(componentName: string, componentVersion: string) {
+    async getDataProvider(
+      componentName: string,
+      componentVersion: string
+    ): Promise<{
+      content: string;
+      filePath: string;
+    }> {
       if (conf.local) {
         return local.getDataProvider(componentName);
       }
@@ -226,14 +246,14 @@ export default function repository(conf: Config) {
 
       return { content, filePath };
     },
-    getStaticClientPath: () =>
+    getStaticClientPath: (): string =>
       `${options!['path']}${getFilePath(
         'oc-client',
         packageInfo.version,
         'src/oc-client.min.js'
       )}`,
 
-    getStaticClientMapPath: () =>
+    getStaticClientMapPath: (): string =>
       `${options!['path']}${getFilePath(
         'oc-client',
         packageInfo.version,
@@ -244,14 +264,14 @@ export default function repository(conf: Config) {
       componentName: string,
       componentVersion: string,
       filePath: string
-    ) =>
+    ): string =>
       `${repository.getComponentPath(componentName, componentVersion)}${
         conf.local ? settings.registry.localStaticRedirectorPath : ''
       }${filePath}`,
 
-    getTemplatesInfo: () => templatesInfo,
+    getTemplatesInfo: (): TemplateInfo[] => templatesInfo,
     getTemplate: (type: string) => templatesHash[type],
-    async init() {
+    async init(): Promise<ComponentsDetails> {
       if (conf.local) {
         // when in local this won't get called
         return 'ok' as any;
@@ -265,7 +285,7 @@ export default function repository(conf: Config) {
       pkgDetails: any,
       componentName: string,
       componentVersion: string
-    ) {
+    ): Promise<ComponentsDetails> {
       if (conf.local) {
         throw {
           code: strings.errors.registry.LOCAL_PUBLISH_NOT_ALLOWED_CODE,

src/registry/index.ts

@@ -81,7 +81,10 @@ export default function registry(inputOptions: Input) {
             ).length;
             const componentsReleases = Object.values(
               componentsInfo.components
-            ).reduce((acc, component) => acc + component.length, 0);
+            ).reduce(
+              (acc, component) => acc + Object.keys(component).length,
+              0
+            );
 
             ok(
               `Registry serving ${componentsNumber} components for a total of ${componentsReleases} releases.`