add option to send custom status code back to the registry

Author: ricardo-devis-agullo

src/registry/routes/helpers/get-component.ts

@@ -275,7 +275,7 @@ export default function getComponent(conf: Config, repository: Repository) {
               err ||
               new Error(strings.errors.registry.DATA_OBJECT_IS_UNDEFINED);
             return callback({
-              status: 500,
+              status: Number(err.status) || 500,
               response: {
                 code: 'GENERIC_ERROR',
                 error: strings.errors.registry.COMPONENT_EXECUTION_ERROR(

test/fixtures/mocked-components/async-custom-error.js

@@ -0,0 +1,28 @@
+'use strict';
+
+module.exports = {
+  package: {
+    name: 'async-custom-error-component',
+    version: '1.0.0',
+    oc: {
+      container: false,
+      renderInfo: false,
+      files: {
+        template: {
+          type: 'jade',
+          hashKey: '8c1fbd954f2b0d8cd5cf11c885fed4805225749f',
+          src: 'template.js'
+        },
+        dataProvider: {
+          type: 'node.js',
+          hashKey: '123457',
+          src: 'server.js'
+        }
+      }
+    }
+  },
+  data: '"use strict";module.exports.data = function(ctx, cb){cb(Object.assign(new Error(), {status: 404}));};',
+  view:
+    'var oc=oc||{};oc.components=oc.components||{},oc.components["8c1fbd954f2b0d8cd5cf11c885fed4805225749f"]' +
+    '=function(){var o=[];return o.push("<div>hello</div>"),o.join("")};'
+};

test/fixtures/mocked-components/index.js

@@ -5,6 +5,7 @@ module.exports = {
   'async-error2-component': require('./async-error2'),
   'async-error3-component': require('./async-error3'),
   'async-error4-component': require('./async-error4'),
+  'async-custom-error-component': require('./async-custom-error'),
   'error-component': require('./error'),
   'npm-component': require('./npm'),
   'plugin-component': require('./plugin'),

test/unit/registry-routes-helpers-get-component.js

@@ -135,6 +135,27 @@ describe('registry : routes : helpers : get-component', () => {
     });
   });
 
+  describe('when the component sends a custom status code', () => {
+    before(done => {
+      initialise(mockedComponents['async-custom-error-component']);
+      const getComponent = GetComponent({}, mockedRepository);
+
+      getComponent(
+        {
+          name: 'async-custom-error-component',
+          headers: {},
+          version: '1.X.X',
+          conf: { baseUrl: 'http://components.com/' }
+        },
+        () => done()
+      );
+    });
+
+    it.only('should return that status code to the client', () => {
+      expect(fireStub.args[0][1].status).to.equal(404);
+    });
+  });
+
   describe('when rendering a component with a legacy template', () => {
     describe("when oc-client requests an unrendered component and it doesn't provide templates header", () => {
       const headers = {