Skip to content

Commit 5cecd29

Browse files
author
jakub.pawlowski
committed
show npm output when installing dependencies
1 parent 361a302 commit 5cecd29

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

src/cli/domain/handle-dependencies/install-compiler.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export default function installCompiler(
1616
): void {
1717
const { compilerPath, componentPath, dependency, logger } = options;
1818

19-
logger.warn(strings.messages.cli.INSTALLING_DEPS(dependency, componentPath), true);
19+
logger.warn(strings.messages.cli.INSTALLING_DEPS(dependency, componentPath));
2020

2121
const npmOptions = {
2222
dependency,

src/cli/domain/handle-dependencies/install-missing-dependencies.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,19 +19,20 @@ export default function installMissingDependencies(
1919

2020
const installPath = path.resolve('.');
2121

22-
logger.warn(strings.messages.cli.INSTALLING_DEPS(missing.join(', '), installPath), true);
22+
logger.warn(strings.messages.cli.INSTALLING_DEPS(missing.join(', '), installPath));
2323

2424
const npmOptions = {
2525
dependencies: missing,
2626
installPath,
2727
save: false,
28-
silent: true,
28+
silent: false,
2929
usePrefix: true
3030
};
3131

3232
npm.installDependencies(npmOptions, err => {
3333
if (err || getMissingDependencies(dependencies).length) {
3434
logger.err('FAIL');
35+
if (err) logger.err(`${err}`);
3536
return callback(strings.errors.cli.DEPENDENCIES_INSTALL_FAIL);
3637
}
3738

src/resources/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ export default {
251251
HOT_RELOADING_DISABLED:
252252
'OC dev is running with hot reloading disabled so changes will be ignored',
253253
INSTALLING_DEPS: (dependencies: string, installPath: string): string =>
254-
`Trying to install missing modules: ${dependencies}\n into ${installPath}/node_modules. If you aren't connected to the internet, or npm isn't configured then this step will fail...`,
254+
`Trying to install missing modules: ${dependencies} into ${installPath}/node_modules.\nIf you aren't connected to the internet, or npm isn't configured then this step will fail...`,
255255
LINKING_DEPENDENCIES: (dependencies: string): string =>
256256
`Trying to link missing modules: ${dependencies}\nThe missing dependencies will be linked to component dependencies`,
257257
MOCKED_PLUGIN: (name: string, value: string): string =>

0 commit comments

Comments
 (0)