Skip to content

Commit 6681ef1

Browse files
eslint --fix on test folder
1 parent 922b511 commit 6681ef1

40 files changed

+270
-191
lines changed

.eslintrc.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
"env": {
44
"browser": true,
55
"es6": true,
6-
"node": true
6+
"node": true,
7+
"mocha": true
78
},
89
"extends": [
910
"eslint:recommended",

test/acceptance/registry-ui.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,10 @@ const path = require('path');
66
const request = require('minimal-request');
77

88
describe('registry (ui interface)', () => {
9-
let registry, result, error, headers;
9+
let registry;
10+
let result;
11+
let error;
12+
let headers;
1013

1114
const next = done => (e, r, d) => {
1215
error = e;

test/acceptance/registry.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,11 @@ const request = require('minimal-request');
77
const _ = require('lodash');
88

99
describe('registry', () => {
10-
let registry, result, error, headers, status;
10+
let registry;
11+
let result;
12+
let error;
13+
let headers;
14+
let status;
1115

1216
const oc = require('../../dist/index');
1317

test/unit/cli-domain-clean.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@ describe('cli : domain : clean', () => {
2323

2424
describe('when fetching the list of folders to clean', () => {
2525
describe('happy path', () => {
26-
let error, result;
26+
let error;
27+
let result;
2728
beforeEach(done => {
2829
const clean = initialize();
2930
clean.fetchList('my-components-folder', (err, res) => {
@@ -59,7 +60,8 @@ describe('cli : domain : clean', () => {
5960

6061
describe('when removing the folders to clean', () => {
6162
describe('happy path', () => {
62-
let error, removeMock;
63+
let error;
64+
let removeMock;
6365
beforeEach(done => {
6466
removeMock = sinon.stub().yields(null, 'ok');
6567
const clean = initialize({ removeMock });
@@ -80,7 +82,8 @@ describe('cli : domain : clean', () => {
8082
});
8183

8284
describe('fs.remove error', () => {
83-
let error, removeMock;
85+
let error;
86+
let removeMock;
8487
beforeEach(done => {
8588
removeMock = sinon.stub().yields(new Error('nope'));
8689
const clean = initialize({ removeMock });

test/unit/cli-domain-get-components-by-dir.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@ const executeComponentsListingByDir = function (local, callback) {
4040

4141
describe('cli : domain : get-components-by-dir', () => {
4242
describe('when getting components from dir', () => {
43-
let error, result;
43+
let error;
44+
let result;
4445
beforeEach(done => {
4546
const data = initialise();
4647

@@ -81,7 +82,8 @@ describe('cli : domain : get-components-by-dir', () => {
8182
});
8283

8384
describe('when reading a broken package.json', () => {
84-
let error, result;
85+
let error;
86+
let result;
8587
beforeEach(done => {
8688
const data = initialise();
8789

@@ -109,7 +111,8 @@ describe('cli : domain : get-components-by-dir', () => {
109111
});
110112

111113
describe('when finds no components', () => {
112-
let error, result;
114+
let error;
115+
let result;
113116
beforeEach(done => {
114117
const data = initialise();
115118

test/unit/cli-domain-get-mocked-plugins.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ describe('cli : domain : get-mocked-plugins', () => {
1414
};
1515

1616
const logMock = { err: _.noop, log: _.noop, ok: _.noop, warn: _.noop };
17-
let fsMock, getMockedPlugins;
17+
let fsMock;
18+
let getMockedPlugins;
1819

1920
const initialise = function (fs, pathJoinStub) {
2021
fsMock = _.extend(
@@ -120,8 +121,8 @@ describe('cli : domain : get-mocked-plugins', () => {
120121
}
121122
};
122123

123-
const readMock = sinon.stub(),
124-
existsMock = sinon.stub();
124+
const readMock = sinon.stub();
125+
const existsMock = sinon.stub();
125126

126127
readMock.withArgs('/root/components/oc.json').returns(ocJsonComponent);
127128
readMock.withArgs('/root/oc.json').returns(ocJsonRoot);

test/unit/cli-domain-handle-dependencies-ensure-compiler-is-declared-as-devDependency.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ describe('cli : domain : handle-dependencies : ensure-compiler-is-declared-as-de
66
const ensure =
77
require('../../dist/cli/domain/handle-dependencies/ensure-compiler-is-declared-as-devDependency').default;
88
describe('when compiler is declared as devDependency', () => {
9-
let error, result;
9+
let error;
10+
let result;
1011
beforeEach(done => {
1112
ensure(
1213
{

test/unit/cli-domain-handle-dependencies-get-compiler.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@ const sinon = require('sinon');
66
const _ = require('lodash');
77

88
describe('cli : domain : handle-dependencies : get-compiler', () => {
9-
let cleanRequireStub, error, installCompilerStub;
9+
let cleanRequireStub;
10+
let error;
11+
let installCompilerStub;
1012
const execute = (opts, done) => {
1113
done = done || opts;
1214
const compilerVersion = opts.compilerVersionEmpty ? '' : '1.2.3';

test/unit/cli-domain-handle-dependencies-install-compiler.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,12 @@ const injectr = require('injectr');
55
const sinon = require('sinon');
66

77
describe('cli : domain : handle-dependencies : install-compiler', () => {
8-
let cleanRequireStub, installDependencyMock, isTemplateValidStub, loggerMock;
9-
let error, result;
8+
let cleanRequireStub;
9+
let installDependencyMock;
10+
let isTemplateValidStub;
11+
let loggerMock;
12+
let error;
13+
let result;
1014

1115
const initialise = (options, done) => {
1216
cleanRequireStub = sinon.stub().returns({ theCompiler: true });

test/unit/cli-domain-handle-dependencies-install-missing-dependencies.js

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ const injectr = require('injectr');
55
const sinon = require('sinon');
66

77
describe('cli : domain : handle-dependencies : install-missing-dependencies', () => {
8-
let error, logger;
8+
let error;
9+
let logger;
910
const initialise = (options, done) => {
1011
const { dependencies, stubs } = options;
1112
logger = {
@@ -32,7 +33,8 @@ describe('cli : domain : handle-dependencies : install-missing-dependencies', ()
3233
};
3334

3435
describe('when there is no missing dependency', () => {
35-
let dependencies, stubs;
36+
let dependencies;
37+
let stubs;
3638
beforeEach(done => {
3739
stubs = {
3840
getMissingDependencies: sinon.stub().returns([]),
@@ -53,7 +55,8 @@ describe('cli : domain : handle-dependencies : install-missing-dependencies', ()
5355
});
5456

5557
describe('when there are missing dependencies and install succeeds', () => {
56-
let dependencies, stubs;
58+
let dependencies;
59+
let stubs;
5760

5861
beforeEach(done => {
5962
stubs = {
@@ -95,7 +98,8 @@ describe('cli : domain : handle-dependencies : install-missing-dependencies', ()
9598
});
9699

97100
describe('when there are missing dependencies and install fails', () => {
98-
let dependencies, stubs;
101+
let dependencies;
102+
let stubs;
99103

100104
beforeEach(done => {
101105
stubs = {
@@ -130,7 +134,8 @@ describe('cli : domain : handle-dependencies : install-missing-dependencies', ()
130134
});
131135

132136
describe('when there are missing dependencies and install succeeds but the dependencies are still not requireable', () => {
133-
let dependencies, stubs;
137+
let dependencies;
138+
let stubs;
134139

135140
beforeEach(done => {
136141
stubs = {

0 commit comments

Comments
 (0)