Merge pull request #1240 from opencomponents/last-ts

Refactor the rest of the remaining src file to TypeScript

Author: ricardo-devis-agullo

.eslintrc.json

@@ -15,238 +15,52 @@
     "sourceType": "module"
   },
   "rules": {
-    "accessor-pairs": "error",
-    "array-bracket-spacing": "off",
-    "array-callback-return": "off",
-    "arrow-body-style": "error",
-    "arrow-parens": "off",
-    "arrow-spacing": [
-      "error",
-      {
-        "after": true,
-        "before": true
-      }
-    ],
-    "block-scoped-var": "off",
-    "block-spacing": "off",
-    "brace-style": "off",
-    "callback-return": "off",
-    "camelcase": "off",
-    "capitalized-comments": "off",
+    "@typescript-eslint/no-unused-vars": "error",
+    "@typescript-eslint/no-explicit-any": "off",
+    "@typescript-eslint/no-non-null-assertion": "off",
+    "@typescript-eslint/explicit-module-boundary-types": "off",
+    "@typescript-eslint/ban-ts-comment": "off",
     "class-methods-use-this": "error",
-    "comma-dangle": "off",
-    "comma-spacing": "off",
-    "comma-style": "off",
-    "complexity": "off",
-    "computed-property-spacing": "off",
-    "consistent-return": "off",
-    "consistent-this": "off",
-    "curly": "off",
     "default-case": "error",
-    "dot-location": ["error", "property"],
-    "dot-notation": "off",
-    "eol-last": ["error", "always"],
-    "eqeqeq": "off",
-    "func-call-spacing": "off",
     "func-name-matching": "error",
-    "func-names": "off",
-    "func-style": "off",
-    "generator-star-spacing": "error",
-    "global-require": "off",
-    "guard-for-in": "off",
-    "handle-callback-err": "off",
-    "id-blacklist": "error",
-    "id-length": "off",
-    "id-match": "error",
-    "indent": ["error", 2],
-    "init-declarations": "off",
-    "jsx-quotes": "error",
-    "key-spacing": "off",
-    "keyword-spacing": "off",
-    "line-comment-position": "off",
-    "linebreak-style": "off",
-    "lines-around-comment": "off",
-    "lines-around-directive": "off",
-    "max-depth": "off",
-    "max-len": "off",
-    "max-lines": "off",
     "max-nested-callbacks": "error",
-    "max-params": "off",
-    "max-statements": "off",
-    "max-statements-per-line": "off",
-    "multiline-ternary": "off",
-    "new-parens": "error",
-    "newline-after-var": "off",
-    "newline-before-return": "off",
-    "newline-per-chained-call": "off",
     "no-alert": "error",
     "no-array-constructor": "error",
-    "no-await-in-loop": "error",
-    "no-bitwise": "off",
     "no-caller": "error",
-    "no-catch-shadow": "off",
-    "no-compare-neg-zero": "error",
-    "no-confusing-arrow": "off",
-    "no-continue": "off",
     "no-console": "warn",
-    "no-div-regex": "error",
     "no-duplicate-imports": "error",
-    "no-else-return": "off",
     "no-empty": [
       "error",
       {
         "allowEmptyCatch": true
       }
     ],
-    "no-empty-function": "off",
-    "no-eq-null": "off",
-    "no-eval": "off",
     "no-extend-native": "error",
-    "no-extra-bind": "error",
     "no-extra-label": "error",
-    "no-extra-parens": "off",
-    "no-floating-decimal": "error",
-    "no-extra-boolean-cast": "warn",
-    "no-implicit-coercion": [
-      "error",
-      {
-        "boolean": false,
-        "number": false,
-        "string": false
-      }
-    ],
     "no-implicit-globals": "error",
     "no-implied-eval": "error",
-    "no-inline-comments": "off",
-    "no-inner-declarations": ["error", "functions"],
-    "no-invalid-this": "off",
     "no-iterator": "error",
     "no-label-var": "error",
     "no-labels": "error",
     "no-lone-blocks": "error",
-    "no-lonely-if": "off",
     "no-loop-func": "error",
-    "no-magic-numbers": "off",
-    "no-mixed-operators": "off",
-    "no-mixed-requires": "off",
-    "no-multi-assign": "off",
-    "no-multi-spaces": "off",
     "no-multi-str": "error",
-    "no-multiple-empty-lines": "off",
-    "no-native-reassign": "error",
-    "no-negated-condition": "off",
-    "no-negated-in-lhs": "error",
-    "no-nested-ternary": "off",
     "no-new": "error",
-    "no-new-func": "off",
     "no-new-object": "error",
-    "no-new-require": "error",
     "no-new-wrappers": "error",
     "no-octal-escape": "error",
-    "no-param-reassign": "off",
-    "no-path-concat": "error",
-    "no-plusplus": "off",
-    "no-process-env": "off",
-    "no-process-exit": "off",
     "no-proto": "error",
-    "no-prototype-builtins": "off",
     "no-restricted-globals": "error",
     "no-restricted-imports": "error",
-    "no-restricted-modules": "error",
     "no-restricted-properties": "error",
     "no-restricted-syntax": "error",
-    "no-return-assign": "off",
     "no-return-await": "error",
     "no-script-url": "error",
-    "no-self-compare": "off",
-    "no-sequences": "off",
-    "no-shadow": "off",
-    "no-shadow-restricted-names": "off",
-    "no-spaced-func": "off",
-    "no-sync": "off",
-    "no-tabs": "off",
-    "no-template-curly-in-string": "off",
-    "no-ternary": "off",
-    "no-throw-literal": "off",
-    "no-trailing-spaces": "error",
-    "no-undef-init": "off",
-    "no-undefined": "off",
-    "no-undef": "off",
-    "no-underscore-dangle": "off",
-    "no-unmodified-loop-condition": "off",
-    "no-unneeded-ternary": "off",
-    "no-unused-expressions": "off",
-    "no-unused-vars": "error",
-    "no-use-before-define": "off",
-    "no-useless-call": "off",
-    "no-useless-computed-key": "error",
-    "no-useless-concat": "off",
     "no-useless-constructor": "error",
-    "no-useless-escape": "off",
-    "no-useless-rename": "error",
     "no-useless-return": "error",
-    "no-var": "error",
-    "no-void": "off",
     "no-warning-comments": "error",
-    "no-whitespace-before-property": "error",
-    "no-with": "error",
-    "nonblock-statement-body-position": ["error", "any"],
-    "object-curly-newline": "off",
-    "object-curly-spacing": "off",
-    "object-property-newline": "off",
-    "object-shorthand": "off",
-    "one-var": "off",
-    "one-var-declaration-per-line": "off",
-    "operator-assignment": "off",
-    "operator-linebreak": "off",
-    "padded-blocks": "off",
-    "prefer-arrow-callback": "error",
-    "prefer-const": "error",
-    "prefer-destructuring": [
-      "error",
-      {
-        "array": false,
-        "object": false
-      }
-    ],
-    "prefer-numeric-literals": "error",
     "prefer-promise-reject-errors": "error",
-    "prefer-reflect": "off",
-    "prefer-rest-params": "off",
-    "prefer-spread": "off",
-    "prefer-template": "off",
-    "quote-props": "off",
-    "quotes": "off",
-    "radix": ["error", "always"],
     "require-await": "error",
-    "require-jsdoc": "off",
-    "rest-spread-spacing": "error",
-    "semi": ["error", "always"],
-    "semi-spacing": "off",
-    "sort-imports": "error",
-    "sort-keys": "off",
-    "sort-vars": "off",
-    "space-before-blocks": "off",
-    "space-before-function-paren": "off",
-    "space-in-parens": "off",
-    "space-infix-ops": "off",
-    "spaced-comment": "off",
-    "strict": "off",
-    "symbol-description": "error",
-    "template-curly-spacing": ["error", "never"],
-    "template-tag-spacing": "error",
-    "unicode-bom": ["error", "never"],
-    "valid-jsdoc": "off",
-    "valid-typeof": [
-      "error",
-      {
-        "requireStringLiterals": false
-      }
-    ],
-    "vars-on-top": "off",
-    "wrap-iife": "off",
-    "wrap-regex": "off",
-    "yield-star-spacing": "error",
-    "yoda": "off"
+    "symbol-description": "error"
   }
 }

package.json

@@ -44,26 +44,38 @@
     "oc"
   ],
   "devDependencies": {
+    "@types/accept-language-parser": "^1.5.2",
+    "@types/async": "^3.2.8",
+    "@types/colors": "1.2.1",
+    "@types/cross-spawn": "^6.0.2",
     "@types/errorhandler": "1.5.0",
     "@types/express": "4.17.13",
+    "@types/fs-extra": "^9.0.13",
+    "@types/livereload": "^0.9.1",
+    "@types/lodash": "^4.14.175",
     "@types/morgan": "1.9.3",
     "@types/multer": "1.4.7",
-    "@types/colors": "1.2.1",
     "@types/node": "16.10.1",
+    "@types/parse-author": "^2.0.1",
+    "@types/read": "0.0.29",
+    "@types/response-time": "^2.3.5",
     "@types/semver": "7.3.8",
+    "@types/targz": "^1.0.1",
     "@types/yargs": "17.0.3",
     "@typescript-eslint/eslint-plugin": "4.32.0",
     "@typescript-eslint/parser": "4.32.0",
     "chai": "4.3.4",
     "chalk": "4.1.2",
+    "eslint": "^7.32.0",
+    "eslint-config-prettier": "^8.3.0",
+    "eslint-plugin-prettier": "^4.0.0",
     "glob": "7.2.0",
     "husky": "7.0.2",
     "injectr": "0.5.1",
     "lint-staged": "11.1.2",
     "minimist": "1.2.5",
     "mocha": "9.1.2",
     "node-emoji": "1.11.0",
-    "oc-template-es6-compiler": "1.1.10",
     "prettier-eslint-cli": "5.0.1",
     "semver-sort": "0.0.4",
     "simple-git": "2.45.1",
@@ -97,12 +109,13 @@
     "oc-empty-response-handler": "1.0.1",
     "oc-get-unix-utc-timestamp": "1.0.3",
     "oc-s3-storage-adapter": "1.1.6",
-    "oc-storage-adapters-utils": "1.0.3",
-    "oc-template-es6": "1.0.3",
-    "oc-template-handlebars": "6.0.21",
-    "oc-template-handlebars-compiler": "6.2.15",
-    "oc-template-jade": "7.0.2",
-    "oc-template-jade-compiler": "7.0.3",
+    "oc-storage-adapters-utils": "1.0.4",
+    "oc-template-es6": "1.0.5",
+    "oc-template-es6-compiler": "1.1.12",
+    "oc-template-handlebars": "6.0.23",
+    "oc-template-handlebars-compiler": "6.2.17",
+    "oc-template-jade": "7.0.4",
+    "oc-template-jade-compiler": "7.0.5",
     "open": "8.2.1",
     "parse-author": "2.0.0",
     "read": "1.0.7",

src/cli/domain/local.js renamed to src/cli/domain/local.ts

@@ -1,32 +1,30 @@
-'use strict';
+import fs from 'fs-extra';
+import targz from 'targz';
 
-const fs = require('fs-extra');
-const targz = require('targz');
-const _ = require('lodash');
+import * as clean from './clean';
+import getComponentsByDir from './get-components-by-dir';
+import initTemplate from './init-template';
+import isTemplateLegacy from '../../utils/is-template-legacy';
+import mock from './mock';
+import packageComponents from './package-components';
+import strings from '../../resources';
+import * as validator from '../../registry/domain/validators';
+import { Local } from '../../types';
 
-const clean = require('./clean');
-const getComponentsByDir = require('./get-components-by-dir').default;
-const initTemplate = require('./init-template').default;
-const isTemplateLegacy = require('../../utils/is-template-legacy').default;
-const mock = require('./mock').default;
-const packageComponents = require('./package-components');
-const strings = require('../../resources').default;
-const validator = require('../../registry/domain/validators');
-
-module.exports = function() {
+export default function local(): Local {
   return {
     clean,
-    cleanup: function(compressedPackagePath, callback) {
+    cleanup(compressedPackagePath: string, callback) {
       return fs.unlink(compressedPackagePath, callback);
     },
-    compress: function(input, output, callback) {
+    compress(input, output, callback) {
       return targz.compress(
         {
           src: input,
           dest: output,
           tar: {
-            map: function(file) {
-              return _.extend(file, {
+            map: function (file) {
+              return Object.assign(file, {
                 name: `_package/${file.name}`
               });
             }
@@ -36,11 +34,11 @@ module.exports = function() {
       );
     },
     getComponentsByDir: getComponentsByDir(),
-    init: function(options, callback) {
+    init(options, callback) {
       const { componentName, logger } = options;
       let { templateType } = options;
       if (!validator.validateComponentName(componentName)) {
-        return callback('name not valid');
+        return callback('name not valid', undefined as any);
       }
 
       // LEGACY TEMPLATES WARNING
@@ -59,17 +57,17 @@ module.exports = function() {
       }
       try {
         initTemplate(
-          _.extend(options, {
+          Object.assign(options, {
             templateType,
             compiler: `${templateType}-compiler`
           }),
-          callback
+          callback as any
         );
       } catch (e) {
-        return callback('template type not valid');
+        return callback('template type not valid', undefined as any);
       }
     },
     mock: mock(),
     package: packageComponents()
   };
-};
+}