Merge pull request #1300 from opencomponents/dev-external-deps

allow for dev version for external dependencies

Author: ricardo-devis-agullo

src/registry/domain/register-templates.ts

@@ -4,7 +4,10 @@ import jadeTemplate from 'oc-template-jade';
 import { Template, TemplateInfo } from '../../types';
 import _ from 'lodash';
 
-export default function registerTemplates(extraTemplates: Template[]): {
+export default function registerTemplates(
+  extraTemplates: Template[],
+  dev = false
+): {
   templatesHash: Record<string, Template>;
   templatesInfo: TemplateInfo[];
 } {
@@ -21,7 +24,14 @@ export default function registerTemplates(extraTemplates: Template[]): {
   }, {} as Record<string, Template>);
 
   const templatesInfo = templates.map(template => {
-    return template.getInfo();
+    const { externals, ...rest } = template.getInfo();
+    return {
+      ...rest,
+      externals: externals.map(({ url, devUrl, ...rest }) => ({
+        ...rest,
+        url: dev && devUrl ? devUrl : url
+      }))
+    };
   });
 
   return {

src/registry/domain/repository.ts

@@ -37,7 +37,10 @@ export default function repository(conf: Config) {
   const getFilePath = (component: string, version: string, filePath: string) =>
     `${options!.componentsDir}/${component}/${version}/${filePath}`;
 
-  const { templatesHash, templatesInfo } = registerTemplates(conf.templates);
+  const { templatesHash, templatesInfo } = registerTemplates(
+    conf.templates,
+    conf.local
+  );
 
   const local = {
     getCompiledView(componentName: string): string {

src/types.ts

@@ -24,6 +24,7 @@ export interface TemplateInfo {
     name: string;
     global: string | string[];
     url: string;
+    devUrl?: string;
   }>;
   type: string;
   version: string;

test/unit/registry-domain-register-templates.js

@@ -24,33 +24,41 @@ describe('registry : domain : register-templates', () => {
   });
 
   describe('when templates get registered with additional templates', () => {
-    const templateMock = {
+    const getTemplateMock = dev => ({
       getInfo() {
         return {
           type: 'new-tpl',
           version: '6.6.6',
-          externals: {}
+          externals: [{ url: 'produrl', ...(dev && { devUrl: 'devurl' }) }]
         };
       }
-    };
+    });
+    const templateMock = getTemplateMock();
+    const devTemplateMock = getTemplateMock(true);
 
-    const registerd = registerTemplates([templateMock]);
+    const registered = registerTemplates([templateMock]);
 
     it('should correctly register core-templates & extra templates', () => {
-      expect(registerd.templatesHash).to.deep.eql({
+      expect(registered.templatesHash).to.deep.eql({
         'oc-template-es6': require('oc-template-es6'),
         'oc-template-jade': require('oc-template-jade'),
         'oc-template-handlebars': require('oc-template-handlebars'),
         'new-tpl': templateMock
       });
-      expect(registerd.templatesInfo).to.deep.eql([
+      expect(registered.templatesInfo).to.deep.eql([
         require('oc-template-es6').getInfo(),
         require('oc-template-jade').getInfo(),
         require('oc-template-handlebars').getInfo(),
         templateMock.getInfo()
       ]);
     });
 
+    const devRegistered = registerTemplates([devTemplateMock], true);
+
+    it('should replace the devurl for the url field', () => {
+      expect(devRegistered.templatesInfo[3].externals[0].url).to.eql('devurl');
+    });
+
     describe('and additional template is already part of core-templates', () => {
       const registered = registerTemplates([require('oc-template-jade')]);